Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5830 - sorted "more photos" by timestamp #5843

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now "more photos" are sorted by descending timestamps, instead of descending ids.

Screenshots

before after
Screenshot_1731409722 Screenshot_1731409831

Fixes bug(s)

Impacted file

  • product_cards_helper.dart: sorted "more photos" by timestamp

Impacted file:
* `product_cards_helper.dart`: sorted "more photos" by timestamp
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 6.92%. Comparing base (4d9c7fc) to head (6cd9490).
Report is 469 commits behind head on develop.

Files with missing lines Patch % Lines
...s/smooth_app/lib/helpers/product_cards_helper.dart 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5843      +/-   ##
==========================================
- Coverage     9.54%   6.92%   -2.63%     
==========================================
  Files          325     422      +97     
  Lines        16411   23249    +6838     
==========================================
+ Hits          1567    1609      +42     
- Misses       14844   21640    +6796     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@monsieurtanuki monsieurtanuki merged commit 3665f05 into openfoodfacts:develop Nov 12, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

"More interesting photos" are not sorted by date
4 participants