-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5855 - no visible product type filter by default #5878
feat: 5855 - no visible product type filter by default #5878
Conversation
Impacted files: * `background_task_price.dart`: minor unrelated fix due to off-dart 3.17.0 * `dao_product.dart`: we overwrite the products product_type with the server product type only if null * `product_query.dart`: now retrieving product_type field in products found on a server * `product_refresher.dart`: unrelated minor refactoring * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded off-dart to 3.17.0 * `search_product_helper.dart`: visible/invisible product type filter, by default invisible and working on food * `user_preferences_dev_mode.dart`: on/off switch for visible product type filter, off by default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5878 +/- ##
==========================================
- Coverage 9.54% 6.74% -2.81%
==========================================
Files 325 433 +108
Lines 16411 23984 +7573
==========================================
+ Hits 1567 1617 +50
- Misses 14844 22367 +7523 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Generally speaking, seems OK. However, we don't want the settings in the DEV mode, but directly in the App Settings, in the Products section (sorry, I wasn't specific enough). |
Understood, but I'm currently visiting family in Italy and I won't be able to change anything before Friday. |
Ok, no pb, I will change it directly in your PR. |
Good. I guess we're all set then. |
Thanks @monsieurtanuki @g123k 📸🧴🐾 |
What
Screenshots
Fixes bug(s)
Impacted files
background_task_price.dart
: minor unrelated fix due to off-dart 3.17.0dao_product.dart
: we overwrite the products product_type with the server product type only if nullproduct_query.dart
: now retrieving product_type field in products found on a serverproduct_refresher.dart
: unrelated minor refactoringpubspec.lock
: wtfpubspec.yaml
: upgraded off-dart to 3.17.0search_product_helper.dart
: visible/invisible product type filter, by default invisible and working on fooduser_preferences_dev_mode.dart
: on/off switch for visible product type filter, off by default