Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "Use photo as" available directly in the gallery (+ a fix) #5916

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 24, 2024

Hi everyone!

To reduce the number of clicks, the action to "use a photo as" is directly available in the gallery:
https://github.com/user-attachments/assets/fcd97d75-4bcd-4359-bebb-e13ff9e0a2e1

There was also a funny issue with the "Add photo" button which was scrolling when the tabs were scrolling (obviously fixed):
https://github.com/user-attachments/assets/605d4ea6-e477-49ee-b51e-195ddc934bfe

@github-actions github-actions bot added 🍎 iOS iOS specific issues or PRs 🥫 Product page labels Nov 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 6.60%. Comparing base (4d9c7fc) to head (9b9d8c8).
Report is 504 commits behind head on develop.

Files with missing lines Patch % Lines
..._app/lib/pages/image/product_image_other_page.dart 0.00% 35 Missing ⚠️
.../pages/image/product_image_gallery_other_view.dart 0.00% 5 Missing ⚠️
...oduct/gallery_view/product_image_gallery_view.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5916      +/-   ##
==========================================
- Coverage     9.54%   6.60%   -2.95%     
==========================================
  Files          325     436     +111     
  Lines        16411   24543    +8132     
==========================================
+ Hits          1567    1621      +54     
- Misses       14844   22922    +8078     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@teolemon
Copy link
Member

@g123k why is it so saving local version for server side cropping ?

Screenshot_20241124-095106.png

@g123k
Copy link
Collaborator Author

g123k commented Nov 24, 2024

I've plugged the feature to the existing one.
Kid you want to change it, we have to change it in the whole app

@teolemon teolemon merged commit b54e461 into openfoodfacts:develop Nov 24, 2024
6 checks passed
@g123k g123k deleted the photo_gallery_3 branch November 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS iOS specific issues or PRs 🥫 Product page
Development

Successfully merging this pull request may close these issues.

3 participants