Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Product page: notify when there are pending operations #5947

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 27, 2024

Hi everyone!

To make users' experience less confusing, there's now a banner on the product page when there are pending edits.
🎥 Video: https://github.com/user-attachments/assets/b1bd365b-3542-44ba-bf27-5531a9d56154

Untitled

Improvement 1: reduce the size of "Compatible"

The translation for "Compatible" in French was incorrect, which allowed me to implement a naive algorithm to reduce the size.
IMG_B02DD6687655-1

Improvement 2: product page title

Sometimes, the product name was vertically cropped on the product page (fixed ✅)
IMG_1481

Improvement 3: picture background has a darker opacity in light mode

Untitled

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 1.63934% with 60 lines in your changes missing coverage. Please review.

Project coverage is 6.53%. Comparing base (4d9c7fc) to head (a01a093).
Report is 530 commits behind head on develop.

Files with missing lines Patch % Lines
...oduct_page/new_product_page_loading_indicator.dart 7.69% 12 Missing ⚠️
packages/smooth_app/lib/widgets/smooth_banner.dart 0.00% 12 Missing ⚠️
...ckages/smooth_app/lib/helpers/color_extension.dart 0.00% 10 Missing ⚠️
...pages/product/product_page/new_product_header.dart 0.00% 10 Missing ⚠️
...kages/smooth_app/lib/resources/app_animations.dart 0.00% 8 Missing ⚠️
...b/pages/product/product_page/new_product_page.dart 0.00% 5 Missing ⚠️
...ib/pages/input/smooth_autocomplete_text_field.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5947      +/-   ##
==========================================
- Coverage     9.54%   6.53%   -3.01%     
==========================================
  Files          325     440     +115     
  Lines        16411   24788    +8377     
==========================================
+ Hits          1567    1621      +54     
- Misses       14844   23167    +8323     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined with the UptoDate product fixes, we'll have a better edit experience 👍

@teolemon
Copy link
Member

@g123k merge conflicta

@g123k g123k force-pushed the product_page_loading branch from 0ef8ecc to a01a093 Compare November 27, 2024 21:35
@teolemon teolemon merged commit 57e13ea into openfoodfacts:develop Nov 27, 2024
6 checks passed
@g123k g123k deleted the product_page_loading branch November 28, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add a refresh indicator on the product page
3 participants