Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improvements for devices with text scale multipliers #5995

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 4, 2024

Hi everyone!

Here are a few fixes for text multipliers.

The nav bar label is on a single line:
IMG_1560

The compatible indicator always fits the space:
IMG_1558

In other photos, the obsolete indicator is not below the text:
IMG_1559

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 6.50%. Comparing base (4d9c7fc) to head (48a4acf).
Report is 549 commits behind head on develop.

Files with missing lines Patch % Lines
...ooth_app/lib/pages/image/product_image_widget.dart 0.00% 3 Missing ⚠️
.../smooth_app/lib/widgets/smooth_navigation_bar.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5995      +/-   ##
==========================================
- Coverage     9.54%   6.50%   -3.05%     
==========================================
  Files          325     441     +116     
  Lines        16411   24979    +8568     
==========================================
+ Hits          1567    1624      +57     
- Misses       14844   23355    +8511     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great @g123k

@g123k g123k merged commit 8bf8299 into openfoodfacts:develop Dec 4, 2024
6 checks passed
@g123k g123k deleted the font_scaler branch December 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants