fix: #687 (2) - product lists loaded from db now only display actual products #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay actual products Impacted file: * `dao_product_extra.dart`: method `getList`, that loads `ProductList`s from the database, does no longer contain barcodes that don't match a `Product`
M123-dev
approved these changes
Nov 27, 2021
| @@ -3,6 +3,7 @@ import 'dart:collection'; | |||
| import 'dart:convert'; | |||
|
|
|||
| import 'package:diacritic/diacritic.dart'; | |||
| import 'package:flutter/cupertino.dart'; | |||
There was a problem hiding this comment.
Doesn't look like it's needed here
There was a problem hiding this comment.
I was surprised, too, when I reviewed my own code.
cupertino.dart is needed for debugPrint later in the code.
Is debugPrint actually needed, probably not, but that's the best I can do for the moment as I cannot reproduce the bug myself.
And thank you for the approval!
This was referenced Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted file:
dao_product_extra.dart: methodgetList, that loadsProductLists from the database, does no longer contain barcodes that don't match aProduct