Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: image list gallery #2724
feat: image list gallery #2724
Changes from 15 commits
d748bc6
27e780b
be68b27
50f1e1d
7b70d61
3e3968c
5d53934
8339953
86af408
ae461e4
cb34353
5a1a91c
2318810
5236428
3693d95
dfcd7b0
862241a
efa58c2
dbcd334
0b580a3
c21aafc
a57a485
7a25112
d44439e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused: is that a list card, like a
Card(child: ListTile(...))
, or is that for pictures?You would probably be better off with 2 distinct classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is like a
Card(child: ListTile(...))
but I added some constructor to facilitate the creation of an inner ListTile with a leading image or a leading icon. Should I create different classes? I don't really know when to create a different class vs just create a delegating constructor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The big misunderstanding is that I never imagined that you would display an image inside a "normal"
ListTile
. I expected something similar to the website: tons of pictures in a grid.I don't know if there were explicit expectations regarding UX/UI, but I must say I'm not a big fan of:
We should start from there: how is it supposed to look? @teolemon Are you OK with the latest screenshots?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does that come from? Why not
103
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I didn't know where to take this from and 100 seems to have a good visual effect. I'm updating the images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand: is that only a "loading" effect for "pictures"? If so call it something like "imageLoading".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a widget that displays the shimmer effect