Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI is not always dark mode friendly #568

Closed
rbovard opened this issue Oct 19, 2021 · 6 comments · Fixed by #928
Closed

UI is not always dark mode friendly #568

rbovard opened this issue Oct 19, 2021 · 6 comments · Fixed by #928

Comments

@rbovard
Copy link

rbovard commented Oct 19, 2021

With official Night mapping theme (QGIS 3.16.11)

Model Baker v6.6.4

image

@signedav
Copy link
Member

Note to myself:
We could get the Color from the QPalette like color(QPalette.WindowText) but this is only for the info-text. For error/success/toppings I don't have an idea yet. Maybe we need to choose a color that fits dark and bright mode.
Or we set the background differently (like gray). But this looks only nice in night mode (not in default mode).
image

@m-kuhn
Copy link
Member

m-kuhn commented Oct 21, 2021

Cc @nirvn do you have a hint?

@signedav signedav self-assigned this Apr 13, 2022
@signedav
Copy link
Member

Maybe we can go for a quick solution as a first step, to have at least a readable dialog.

@signedav signedav removed their assignment Apr 20, 2022
@gacarrillor
Copy link
Collaborator

gacarrillor commented Jun 11, 2024

Some findings:

  • Schema Import / Import data
    • Model (.ili) icon 👁️‍🗨️️
    • DB panel input widgets 👁️‍🗨️️
    • Log 👁️‍🗨️️
    • Message in progressbar 👁️‍🗨️️
  • Generate project
    • DB panel input widgets 👁️‍🗨️️
    • Configure OID generation
      • ε button for expressions 👁️‍🗨️️ 💚
    • Log 👁️‍🗨️️
    • Message in progressbar 👁️‍🗨️️
  • Export Data
    • DB panel input widgets 👁️‍🗨️️
    • Log 👁️‍🗨️️
    • Message in progressbar 👁️‍🗨️️
  • Dataset manager
    • Checkboxes in Manage baskets 💦 ☔ (checkboxes in other dialogs show a white thick on green background)
    • DB panel input widgets 👁️‍🗨️️
  • Usability Hub Topping Maker Wizard
  • OID manager
    • Show column checkboxes ☔
  • Data Validator
    • Message in progressbar 👁️‍🗨️️
    • Placeholder text for config file [in general, QGIS placeholders as well] ☔
    • Main validate button icon does not stand out (it might also lacks a tooltip) ☔

👁️‍🗨️️ : Unreadable/almost invisible
💚 : QGIS issue (not fixed)
💦 : Not easy solution
☔ : We can live with it (not fixed)

@signedav
Copy link
Member

Cool. What about validator and the selector in the toolboxes (two features people use while working on the data)?

@gacarrillor
Copy link
Collaborator

Cool. What about validator and the selector in the toolboxes (two features people use while working on the data)?

Just updated the diagnosis, and yes, the selector in the toolbox looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants