Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

[frontend][backend] create shared types for those used across frontend and backend #209

Closed
zxt-tzx opened this issue Mar 28, 2022 · 3 comments · Fixed by #399
Closed

[frontend][backend] create shared types for those used across frontend and backend #209

zxt-tzx opened this issue Mar 28, 2022 · 3 comments · Fixed by #399
Labels

Comments

@zxt-tzx
Copy link
Contributor

zxt-tzx commented Mar 28, 2022

Currently building out backend and it seems to me that the DTOs are shared types across frontend and backend and that we should put them in a shared folder like in AskGov.

(actually not entirely sure about this, since the DTOs on the backend uses decorators, but not those on the frontend hmm)

Wonder if this could be more general (i.e. not just DTOs, but other types too)

@zxt-tzx
Copy link
Contributor Author

zxt-tzx commented Apr 24, 2022

Might be useful to refer to opengovsg/askgovsg#216

Related TODOs added in #293

@zxt-tzx
Copy link
Contributor Author

zxt-tzx commented Apr 28, 2022

Look into how nemsw does it (apparently using turborepo).

UPDATE 1: also relevant: https://www.robinwieruch.de/javascript-monorepos/

UPDATE 2: aborted; not using Turborepo after all, see #376 (comment)

@zxt-tzx zxt-tzx added the p3 label May 12, 2022
@zxt-tzx
Copy link
Contributor Author

zxt-tzx commented May 13, 2022

More TODOs added in #308

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant