This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
feat(enquiries): suggest existing questions to the user #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refine default handleSubmit flag to just push history; regardless of specified hook, GA event will be sent - add handleAbandon hook, capturing when a search is abandoned - allow search icon to be disabled by setting `showSearchIcon` to false
LoneRifle
force-pushed
the
feat/enquiries/suggest
branch
from
bc5da92 to
816505e
Compare
|
pressing enter on question title in enquiry modal now leads to search page |
good catch! added a flag to control this behaviour. |
|
|
LoneRifle
force-pushed
the
feat/enquiries/suggest
branch
from
baf3ea9 to
dd9a001
Compare
|
spotted and corrected the missing |
nauynix
reviewed
Sep 2, 2021
LoneRifle
force-pushed
the
feat/enquiries/suggest
branch
from
b92f157 to
0ece128
Compare
LoneRifle
force-pushed
the
feat/enquiries/suggest
branch
from
0ece128 to
30411b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #173
Solution
specified hook, GA event will be sent
showSearchIconto falseScreenshot