-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pushover] Mandatory title in messages #9279
Comments
Yes, that is right. But adding hundreds of methods to cover all possible combinations of parameters is not a good design. As stated in #8586 (comment) I would rather investigate on exposing the message builder which is way more flexible and a basic pattern. |
Oh, wait. I think this might be my fault. I interpreted the "@nullable" in the documentation as the second argument being optional, but it isn't, is it? I guess that means I have to provide the argument anyway, just that it can be null? (btw, I wonder what happened to the link to the documentation that I put in this ticket, it certainly doesn't link to the place it should...) |
It was:
But it should have been used like:
If you don't want to provide a text for the link... just post the link 😉 |
Yes you still need to provide a |
Understood. Guess I'll close this ticket then. I guess the documentation could be a little bit more clear, but maybe it is for people in the world of Java :-) |
According to the documentation at http://next.openhab.org/addons/bindings/pushover/ the second argument to sendMessage() should be optional, but when trying to call the method with only one argument I get the following error:
When providing two arguments (message and title) everything works as it should.
This is the version of the binding provided in 3.0 M5.
The text was updated successfully, but these errors were encountered: