Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Omniscape.jl: Software to predict omni-directional landscape connectivity #2777

Closed
whedon opened this issue Oct 24, 2020 · 38 comments

Comments

@whedon
Copy link

whedon commented Oct 24, 2020

Submitting author: @vlandau (Vincent Landau)
Repository: https://github.com/Circuitscape/Omniscape.jl
Version: v0.4.3
Editor: @melissawm
Reviewers: @juliohm, @tpoisot
Managing EiC: Kyle Niemeyer

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @vlandau. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @karthik.

@vlandau if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Oct 24, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Oct 24, 2020

Failed to discover a Statement of need section in paper

@whedon
Copy link
Author

whedon commented Oct 24, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.11 s (355.0 files/s, 27852.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           10            312            123           1436
Markdown                         5            129              0            299
INI                             13             55              0            272
SVG                              1              0              0            143
TeX                              1              6              0             67
YAML                             4             12              5             66
TOML                             2              3              0             24
Dockerfile                       1              5              3             14
CSS                              1              1              0              6
-------------------------------------------------------------------------------
SUM:                            38            523            131           2327
-------------------------------------------------------------------------------


Statistical information for the repository 'a2bfece65154bbf521f209ba' was
gathered on 2020/10/24.
No commited files with the specified extensions were found.

@whedon
Copy link
Author

whedon commented Oct 24, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/jcon.00058 is OK

MISSING DOIs

- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- 10.1890/07-1861.1 may be a valid DOI for title: Using circuit theory to model connectivity in ecology, evolution, and conservation

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Oct 24, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

Hey @karthik, I realize a Julia package is a bit outside your usual wheelhouse, but could you edit this one?

@kyleniemeyer
Copy link

@whedon invite @karthik as editor

@whedon
Copy link
Author

whedon commented Oct 24, 2020

@karthik has been invited to edit this submission.

@karthik
Copy link
Contributor

karthik commented Oct 24, 2020

👋 @kyleniemeyer
Thanks for the invitation. This submission is well outside my scope of expertise. I also had a very challenging time finding reviewers last time I handled a Julia submission. For these reasons I'd like to decline this one. 🙏

@vlandau
Copy link

vlandau commented Oct 25, 2020

Timothee Poisot (tpoisot) has offered to review this paper/software. From the spreadsheet of potential reviewers, arbennett, r-barnes, and juliohm look like excellent fits.

@kyleniemeyer
Copy link

@karthik understood, no worries.

Hi @melissawm, as one of our "official" Julia editors 😀, could you take this on?

@arfon
Copy link
Member

arfon commented Oct 28, 2020

@whedon invite @melissawm as editor

@whedon
Copy link
Author

whedon commented Oct 28, 2020

@melissawm has been invited to edit this submission.

@melissawm
Copy link

Hi all, I'll be happy to even though the subject is not one I'm totally familiar with.

@melissawm
Copy link

@whedon assign @melissawm as editor

@whedon
Copy link
Author

whedon commented Oct 28, 2020

OK, the editor is @melissawm

@vlandau
Copy link

vlandau commented Oct 29, 2020

@whedon commands

@whedon
Copy link
Author

whedon commented Oct 29, 2020

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@melissawm
Copy link

Hello @vlandau! I'll proceed with inviting reviewers, could you please check the DOI issues listed above?

@melissawm
Copy link

👋 @tpoisot, @juliohm would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html Let me know if you have any further questions. Thank you!

@juliohm
Copy link

juliohm commented Nov 2, 2020

I would be happy to review the submission @melissawm 👍

@melissawm
Copy link

@whedon assign @juliohm as reviewer

@whedon whedon assigned juliohm and melissawm and unassigned melissawm Nov 2, 2020
@whedon
Copy link
Author

whedon commented Nov 2, 2020

OK, @juliohm is now a reviewer

@vlandau
Copy link

vlandau commented Nov 2, 2020

@whedon generate pdf

@vlandau
Copy link

vlandau commented Nov 2, 2020

@whedon check references

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.0014-3820.2006.tb00500.x is OK
- 10.1137/141000671 is OK
- 10.1890/07-1861.1 is OK
- 10.1890/07-1861.1 is OK
- 10.21105/jcon.00058 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Nov 2, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@vlandau
Copy link

vlandau commented Nov 2, 2020

@whedon check references

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.0014-3820.2006.tb00500.x is OK
- 10.1137/141000671 is OK
- 10.1890/07-1861.1 is OK
- 10.1111/cobi.13230 is OK
- 10.21105/jcon.00058 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@tpoisot
Copy link

tpoisot commented Nov 6, 2020

grabs 🎤 to give some completely unsolicited advice

I'm happy to review this one, I used Omniscape a lot. I know that @VLucet and @glaroc also did, and would be suitable reviewers as well.

@VLucet
Copy link

VLucet commented Nov 6, 2020

Thanks @tpoisot for thinking of me! I actually have not had the chance to test Omniscape yet. I know @glaroc did and would therefore be better suited. I have used Circuitscape (Julia version) quite a bit. I'm unsure whether having this perspective fully qualifies me to be a reviewer.

@melissawm
Copy link

Thanks, @tpoisot !

With this, we'll already have two reviewers which is the minimum for the review process to go forward, but I'd be happy to add a third reviewer, too - @vlandau do you have a preference?

@melissawm
Copy link

@whedon add @tpoisot as reviewer

@whedon whedon assigned juliohm, melissawm and tpoisot and unassigned juliohm and melissawm Nov 9, 2020
@whedon
Copy link
Author

whedon commented Nov 9, 2020

OK, @tpoisot is now a reviewer

@vlandau
Copy link

vlandau commented Nov 9, 2020

@melissawm I'm good either way. Lowest-hanging fruit may be to just go with the two we have. Thanks!

@melissawm
Copy link

Then we're good - I'll assign the reviewers and this issue will be automatically closed by whedon - we'll meet at the review issue. Thank you, all!

@melissawm
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 9, 2020

OK, I've started the review over in #2829.

@whedon whedon closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants