Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: lvlspy: A Python Package for Quantum Level Systems #5933

Closed
editorialbot opened this issue Oct 10, 2023 · 13 comments
Closed

[PRE REVIEW]: lvlspy: A Python Package for Quantum Level Systems #5933

editorialbot opened this issue Oct 10, 2023 · 13 comments
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Shell TeX Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @jaadt7 (Jaad Tannous)
Repository: https://github.com/jaadt7/lvlspy.git
Branch with paper.md (empty if default branch):
Version: v3.0.2
Editor: Pending
Reviewers: Pending
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9b69964c7f6f238b63bbc3008f72f446"><img src="https://joss.theoj.org/papers/9b69964c7f6f238b63bbc3008f72f446/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9b69964c7f6f238b63bbc3008f72f446/status.svg)](https://joss.theoj.org/papers/9b69964c7f6f238b63bbc3008f72f446)

Author instructions

Thanks for submitting your paper to JOSS @jaadt7. Currently, there isn't a JOSS editor assigned to your paper.

@jaadt7 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Oct 10, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (736.8 files/s, 52858.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          10            346            469            597
reStructuredText                 7             93             51            137
YAML                             5             12             16             95
TeX                              1              3              0             40
Markdown                         1             12              0             31
Bourne Shell                     2              3              1             11
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            27            473            543            921
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.8193378 is OK

MISSING DOIs

- 10.3847/1538-4365/abc41d may be a valid DOI for title: Astromers: nuclear isomers in astrophysics

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 687

@kyleniemeyer
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Oct 10, 2023
@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

Hello @jaadt7, thanks for your interest in JOSS. Due to the relatively small nature of your submission (in terms of lines of code), the editorial board is going to review to make sure it meets our requirements for substantial scholarly effort. We should get back to you within a week or so.

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PyTeNet: A concise Python implementation of quantum tensor network algorithms
Submitting author: @cmendl
Handling editor: @jedbrown (Active)
Reviewers: @mlxd, @jcmgray
Similarity score: 0.8087

pyscal: A python module for structural analysis of atomic environments
Submitting author: @srmnitc
Handling editor: @melissawm (Retired)
Reviewers: @lucydot, @bocklund
Similarity score: 0.8073

SkyPy: A package for modelling the Universe
Submitting author: @rrjbca
Handling editor: @arfon (Active)
Reviewers: @cescalara, @rmorgan10
Similarity score: 0.8001

SpiceyPy: a Pythonic Wrapper for the SPICE Toolkit
Submitting author: @andrewannex
Handling editor: @mbobra (Active)
Reviewers: @hayesla, @jessie-dotson
Similarity score: 0.8000

polypy - Analysis Tools for Solid State Molecular Dynamics and Monte Carlo Trajectories
Submitting author: @symmy596
Handling editor: @richardjgowers (Active)
Reviewers: @hmacdope, @lscalfi
Similarity score: 0.7973

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@jaadt7
Copy link

jaadt7 commented Nov 3, 2023

Hello @kyleniemeyer, was wondering if there is an ETA from the editorial board regarding their decision for the substantial scholarly effort.

@kyleniemeyer
Copy link

Hi @jaadt7, thanks for your patience. Unfortunately, after some review, the JOSS editorial has found that your submission does not meet our requirements for substantial scholarly effort, due to the small size. It was also a bit unclear what need it is serving.

However, one editor noted that the notebook tutorials linked from the docs actually have a lot of interesting functionality, and if these became part of the package, then it might be in scope.

As it stands, we encourage you to take advantage of some other venues for archiving/publishing your work, including following GitHub's guide on how to create a permanent archive and get a citable DOI for your software.

@kyleniemeyer
Copy link

@editorialbot reject

@editorialbot
Copy link
Collaborator Author

Paper rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python query-scope Submissions of uncertain scope for JOSS rejected Shell TeX Track: 3 (PE) Physics and Engineering
Projects
None yet
Development

No branches or pull requests

3 participants