[REVIEW]: quadkeyr: Tools for converting QuadKey-identified datasets (Microsoft's Bing Maps Tile System) into raster images and analyzing Meta (Facebook) Mobility Data #6500

editorialbot · 2024-03-17T11:09:55Z

Submitting author: @flor14 (María Florencia D'Andrea)
Repository: https://github.com/ropensci/quadkeyr
Branch with paper.md (empty if default branch):
Version: v0.1.0
Editor: @osorensen
Reviewers: @osorensen
Archive: 10.5281/zenodo.10835288

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3301002821465f4f160e7ce272c00c6f"><img src="https://joss.theoj.org/papers/3301002821465f4f160e7ce272c00c6f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3301002821465f4f160e7ce272c00c6f/status.svg)](https://joss.theoj.org/papers/3301002821465f4f160e7ce272c00c6f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@osorensen, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@osorensen, please create your checklist typing: @editorialbot generate my checklist

The text was updated successfully, but these errors were encountered:

editorialbot · 2024-03-17T11:09:58Z

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot · 2024-03-17T11:10:14Z

Software report:

github.com/AlDanial/cloc v 1.90  T=0.34 s (395.7 files/s, 170844.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            41           1221            124          27638
JavaScript                      13           2723           2177           8785
CSS                             20             22            156           7730
R                               33            343           1279           1874
JSON                             5             12              0            908
CSV                              3              0              0            453
Rmd                              5            277            723            371
SVG                              2              0              1            299
Markdown                         4             85              0            274
YAML                             6             19             12            167
XML                              1              0              0            129
TeX                              1              0              0             59
-------------------------------------------------------------------------------
SUM:                           134           4702           4472          48687
-------------------------------------------------------------------------------

Commit count by author:

   103	Florencia D'Andrea

editorialbot · 2024-03-17T11:10:18Z

Paper file info:

📄 Wordcount for paper.md is 998

✅ The paper includes a Statement of need section

editorialbot · 2024-03-17T11:10:20Z

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot · 2024-03-17T11:10:25Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/RJ-2018-009 is OK
- 10.1201/9780429459016 is OK

MISSING DOIs

- No DOI given, and none found for title: Bing Maps Tile System - Bing Maps
- No DOI given, and none found for title: slippymath: Slippy Map Tile Tools
- Entry without DOI or title found
- No DOI given, and none found for title: Applied spatial data analysis with R, Second editi...
- No DOI given, and none found for title: raster: Geographic Data Analysis and Modeling
- No DOI given, and none found for title: Preparing CRAN for the retirement of rgdal, rgeos ...
- No DOI given, and none found for title: Edzer Pebesma, Roger Bivand

INVALID DOIs

- None

osorensen · 2024-03-17T11:10:45Z

This packagehas been published on rOpenSci. Here is a link to the review issue: ropensci/software-review#619

editorialbot · 2024-03-17T11:10:57Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

osorensen · 2024-03-17T11:11:01Z

@editorialbot generate pdf

osorensen · 2024-03-17T11:12:04Z

@editorialbot check references

editorialbot · 2024-03-17T11:12:14Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

editorialbot · 2024-03-17T11:12:31Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/RJ-2018-009 is OK
- 10.1201/9780429459016 is OK

MISSING DOIs

- No DOI given, and none found for title: Bing Maps Tile System - Bing Maps
- No DOI given, and none found for title: slippymath: Slippy Map Tile Tools
- Entry without DOI or title found
- No DOI given, and none found for title: Applied spatial data analysis with R, Second editi...
- No DOI given, and none found for title: raster: Geographic Data Analysis and Modeling
- No DOI given, and none found for title: Preparing CRAN for the retirement of rgdal, rgeos ...
- No DOI given, and none found for title: Edzer Pebesma, Roger Bivand

INVALID DOIs

- None

osorensen · 2024-03-17T11:33:49Z

@flor14: the paths to all the figures in the paper seem broken.

For example, the paper directory contains the file bing_tiles.jpg, but paper.md contains the line ![Tile coordinates. Image extracted from Microsoft’s Bing Maps Tile System webpage. \label{fig:fig3}](vignettes/bing_tiles.jpg). My last pull request attempts to fix some of this, but I think it's better that you go carefully through all the figures, make corrections and ping me here when done. Feel free to test your code with @editorialbot generate pdf in this thread, as much as you like.

flor14 · 2024-03-17T16:40:26Z

Thank you, @osorensen. Yes, I am working on improving the citations and fixing the image links.

flor14 · 2024-03-17T16:40:46Z

@editorialbot generate pdf

editorialbot · 2024-03-17T16:41:48Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

osorensen · 2024-03-17T17:11:25Z

@editorialbot check references

editorialbot · 2024-03-17T17:11:43Z

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "f987016d320687e002992d7e62599fe89d0" (NAME) [#<BibTeX::Bibliography data=[7]>, "@", #<BibTeX::Entry >, {:author=>["Roger Bivand and Edzer Pebesma and Jakub Nowosad and Jose A. Hernandez "], :title=>["Preparing CRAN for the retirement of rgdal, rgeos and maptools"], :year=>["2024"], :publisher=>["GitHub"], :journal=>["GitHub repository"], :howpublished=>["\\url{https://github.com/r-spatial/evolution}"], :commit=>"03612"}]

flor14 · 2024-03-17T18:03:38Z

@editorialbot generate pdf

flor14 · 2024-03-17T18:04:25Z

@editorialbot check references

editorialbot · 2024-03-17T18:04:44Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

editorialbot · 2024-03-17T18:04:46Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/RJ-2018-009 is OK
- 10.1201/9780429459016 is OK

MISSING DOIs

- No DOI given, and none found for title: Bing Maps Tile System - Bing Maps. Microsoft Learn...
- No DOI given, and none found for title: slippymath: Slippy Map Tile Tools
- No DOI given, and none found for title: Data For Good at Meta Website
- No DOI given, and none found for title: Applied spatial data analysis with R, Second editi...
- No DOI given, and none found for title: raster: Geographic Data Analysis and Modeling
- No DOI given, and none found for title: Preparing CRAN for the retirement of rgdal, rgeos ...
- No DOI given, and none found for title: R-spatial evolution: retirement of rgdal, rgeos an...
- No DOI given, and none found for title: rgdal: Bindings for the ’Geospatial’ Data Abstract...
- No DOI given, and none found for title: rgeos: Interface to Geometry Engine - Open Source ...
- No DOI given, and none found for title: maptools: Tools for Handling Spatial Objects

INVALID DOIs

- None

editorialbot · 2024-03-18T19:54:03Z

Done! archive is now 10.5281/zenodo.10835288

osorensen · 2024-03-18T19:54:06Z

@editorialbot recommend-accept

editorialbot · 2024-03-18T19:54:08Z

Attempting dry run of processing paper acceptance...

editorialbot · 2024-03-18T19:54:26Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/RJ-2018-009 is OK
- 10.1201/9780429459016 is OK

MISSING DOIs

- No DOI given, and none found for title: Bing Maps Tile System - Bing Maps. Microsoft Learn...
- No DOI given, and none found for title: slippymath: Slippy Map Tile Tools
- No DOI given, and none found for title: Data For Good at Meta Website
- No DOI given, and none found for title: Applied spatial data analysis with R, Second editi...
- No DOI given, and none found for title: raster: Geographic Data Analysis and Modeling
- No DOI given, and none found for title: Preparing CRAN for the retirement of rgdal, rgeos ...
- No DOI given, and none found for title: R-spatial evolution: retirement of rgdal, rgeos an...
- No DOI given, and none found for title: rgdal: Bindings for the ’Geospatial’ Data Abstract...
- No DOI given, and none found for title: rgeos: Interface to Geometry Engine - Open Source ...
- No DOI given, and none found for title: maptools: Tools for Handling Spatial Objects

INVALID DOIs

- None

editorialbot · 2024-03-18T19:55:45Z

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5147, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

flor14 · 2024-03-18T20:03:45Z

Not sure if I am the one who should accept it but looks good to me.

osorensen · 2024-03-18T20:10:06Z

The editor-in-chief will read through and accept. Typically takes a few days.

flor14 · 2024-03-18T20:12:02Z

Thank you @osorensen for all your changes, I think you have been the best editor I've ever had.

oliviaguest · 2024-03-19T08:33:27Z

@editorialbot recommend-accept

editorialbot · 2024-03-19T08:33:29Z

Attempting dry run of processing paper acceptance...

editorialbot · 2024-03-19T08:33:56Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/RJ-2018-009 is OK
- 10.1201/9780429459016 is OK

MISSING DOIs

- No DOI given, and none found for title: Bing Maps Tile System - Bing Maps. Microsoft Learn...
- No DOI given, and none found for title: slippymath: Slippy Map Tile Tools
- No DOI given, and none found for title: Data For Good at Meta Website
- No DOI given, and none found for title: Applied spatial data analysis with R, Second editi...
- No DOI given, and none found for title: raster: Geographic Data Analysis and Modeling
- No DOI given, and none found for title: Preparing CRAN for the retirement of rgdal, rgeos ...
- No DOI given, and none found for title: R-spatial evolution: retirement of rgdal, rgeos an...
- No DOI given, and none found for title: rgdal: Bindings for the ’Geospatial’ Data Abstract...
- No DOI given, and none found for title: rgeos: Interface to Geometry Engine - Open Source ...
- No DOI given, and none found for title: maptools: Tools for Handling Spatial Objects

INVALID DOIs

- None

editorialbot · 2024-03-19T08:35:17Z

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5148, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

oliviaguest · 2024-03-19T08:43:11Z

are those DOIs OK? ☺️

flor14 · 2024-03-19T18:09:06Z

These missing DOIs are from software packages or websites that don't have DOIs assigned.

oliviaguest · 2024-03-25T09:28:05Z

@editorialbot recommend-accept

editorialbot · 2024-03-25T09:28:07Z

Attempting dry run of processing paper acceptance...

editorialbot · 2024-03-25T09:29:31Z

👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5171, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

oliviaguest · 2024-03-25T09:31:32Z

@editorialbot accept

editorialbot · 2024-03-25T09:31:33Z

Doing it live! Attempting automated processing of paper acceptance...

editorialbot · 2024-03-25T09:33:59Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/RJ-2018-009 is OK
- 10.1201/9780429459016 is OK

MISSING DOIs

- No DOI given, and none found for title: Bing Maps Tile System - Bing Maps. Microsoft Learn...
- No DOI given, and none found for title: slippymath: Slippy Map Tile Tools
- No DOI given, and none found for title: Data For Good at Meta Website
- No DOI given, and none found for title: Applied spatial data analysis with R, Second editi...
- No DOI given, and none found for title: raster: Geographic Data Analysis and Modeling
- No DOI given, and none found for title: Preparing CRAN for the retirement of rgdal, rgeos ...
- No DOI given, and none found for title: R-spatial evolution: retirement of rgdal, rgeos an...
- No DOI given, and none found for title: rgdal: Bindings for the ’Geospatial’ Data Abstract...
- No DOI given, and none found for title: rgeos: Interface to Geometry Engine - Open Source ...
- No DOI given, and none found for title: maptools: Tools for Handling Spatial Objects

INVALID DOIs

- None

editorialbot · 2024-03-25T09:38:37Z

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: D'Andrea
  given-names: Florencia
  orcid: "https://orcid.org/0000-0002-0041-097X"
- family-names: Fernandez
  given-names: Pilar
  orcid: "https://orcid.org/0000-0001-8645-2267"
contact:
- family-names: D'Andrea
  given-names: Florencia
  orcid: "https://orcid.org/0000-0002-0041-097X"
- family-names: Fernandez
  given-names: Pilar
  orcid: "https://orcid.org/0000-0001-8645-2267"
doi: 10.5281/zenodo.10835288
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: D'Andrea
    given-names: Florencia
    orcid: "https://orcid.org/0000-0002-0041-097X"
  - family-names: Fernandez
    given-names: Pilar
    orcid: "https://orcid.org/0000-0001-8645-2267"
  date-published: 2024-03-25
  doi: 10.21105/joss.06500
  issn: 2475-9066
  issue: 95
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6500
  title: "quadkeyr: Tools for converting QuadKey-identified datasets
    (Microsoft's Bing Maps Tile System) into raster images and analyzing
    Meta (Facebook) Mobility Data"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06500"
  volume: 9
title: "quadkeyr: Tools for converting QuadKey-identified datasets
  (Microsoft's Bing Maps Tile System) into raster images and analyzing
  Meta (Facebook) Mobility Data"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot · 2024-03-25T09:38:42Z

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot · 2024-03-25T09:38:43Z

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.06500 joss-papers#5172
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06500
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

oliviaguest · 2024-03-26T08:51:39Z

Thanks @osorensen and congrats @flor14 🎉

editorialbot · 2024-03-26T08:51:41Z

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06500/status.svg)](https://doi.org/10.21105/joss.06500)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06500">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06500/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06500/status.svg
   :target: https://doi.org/10.21105/joss.06500

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

editorialbot added R review TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Mar 17, 2024

editorialbot assigned osorensen Mar 17, 2024

editorialbot mentioned this issue Mar 17, 2024

[PRE REVIEW]: quadkeyr: Tools for converting QuadKeys (Microsoft's Bing Maps Tile System) into raster images #6499

Closed

This was referenced Mar 17, 2024

Update paper.md ropensci/quadkeyr#9

Closed

Update paper.md ropensci/quadkeyr#8

Closed

osorensen mentioned this issue Mar 17, 2024

Update paper.md ropensci/quadkeyr#10

Closed

editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Mar 18, 2024

editorialbot added accepted published Papers published in JOSS labels Mar 25, 2024

oliviaguest closed this as completed Mar 26, 2024

oliviaguest added the rOpenSci Submissions associated with rOpenSci label Mar 29, 2024

[REVIEW]: quadkeyr: Tools for converting QuadKey-identified datasets (Microsoft's Bing Maps Tile System) into raster images and analyzing Meta (Facebook) Mobility Data #6500

[REVIEW]: quadkeyr: Tools for converting QuadKey-identified datasets (Microsoft's Bing Maps Tile System) into raster images and analyzing Meta (Facebook) Mobility Data #6500

Comments

editorialbot commented Mar 17, 2024 • edited Loading

Status

Reviewer instructions & questions

Checklists

editorialbot commented Mar 17, 2024

editorialbot commented Mar 17, 2024

editorialbot commented Mar 17, 2024

editorialbot commented Mar 17, 2024

editorialbot commented Mar 17, 2024

osorensen commented Mar 17, 2024

editorialbot commented Mar 17, 2024

osorensen commented Mar 17, 2024

osorensen commented Mar 17, 2024

editorialbot commented Mar 17, 2024

editorialbot commented Mar 17, 2024

osorensen commented Mar 17, 2024

flor14 commented Mar 17, 2024

flor14 commented Mar 17, 2024

editorialbot commented Mar 17, 2024

osorensen commented Mar 17, 2024

editorialbot commented Mar 17, 2024

flor14 commented Mar 17, 2024

flor14 commented Mar 17, 2024

editorialbot commented Mar 17, 2024

editorialbot commented Mar 17, 2024

editorialbot commented Mar 18, 2024

osorensen commented Mar 18, 2024

editorialbot commented Mar 18, 2024

editorialbot commented Mar 18, 2024

editorialbot commented Mar 18, 2024

flor14 commented Mar 18, 2024

osorensen commented Mar 18, 2024

flor14 commented Mar 18, 2024

oliviaguest commented Mar 19, 2024

editorialbot commented Mar 19, 2024

editorialbot commented Mar 19, 2024

editorialbot commented Mar 19, 2024

oliviaguest commented Mar 19, 2024

flor14 commented Mar 19, 2024

oliviaguest commented Mar 25, 2024

editorialbot commented Mar 25, 2024

editorialbot commented Mar 25, 2024

oliviaguest commented Mar 25, 2024

editorialbot commented Mar 25, 2024

editorialbot commented Mar 25, 2024

editorialbot commented Mar 25, 2024

editorialbot commented Mar 25, 2024

editorialbot commented Mar 25, 2024

oliviaguest commented Mar 26, 2024

editorialbot commented Mar 26, 2024

editorialbot commented Mar 17, 2024 •

edited

Loading