Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Rework editing of permissions #245

Closed
mathiashoeld opened this issue Apr 29, 2019 · 0 comments · Fixed by #387
Closed

ui: Rework editing of permissions #245

mathiashoeld opened this issue Apr 29, 2019 · 0 comments · Fixed by #387
Assignees
Labels
feature Indicates a new feature implementation

Comments

@mathiashoeld
Copy link
Contributor

mathiashoeld commented Apr 29, 2019

Current situation

When editing permissions, each click performs an API action and grants/revokes permissions. This is not ideal for some reasons:

  • If an error was made, it is written permanently to the chain
  • The scenario where a user grants permissions, but cannot revoke them is possible - which combined with the first issue can cause problems
  • There is no way to restore the original state during edit (i.e. no "cancel" button)

Proposed solution

Similar to the drawer in the batch edit function for workflowitems, the permissions should be changed in the permissions window without any action on API level and only after click of "apply" the changes are persisted to the chain.
Additionally, add a "cancel" button that simply cancels the process and takes the user back to the previous screen.
This should be done for global permissions as well as permissions for projects/subprojects/workflowitems.

@mathiashoeld mathiashoeld added the feature Indicates a new feature implementation label Apr 29, 2019
@mathiashoeld mathiashoeld added this to the TruBudget 1.1.0 milestone Apr 30, 2019
@Stezido Stezido self-assigned this May 28, 2019
@mathiashoeld mathiashoeld assigned mathiashoeld and unassigned Stezido Aug 12, 2019
@mathiashoeld mathiashoeld modified the milestones: TruBudget 1.x.x, Trubudget 1.4.0 Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants