Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/ui: Its possible to revoke"grant permission" from last user of a workflowitem #514

Closed
Stezido opened this issue Jul 6, 2020 · 1 comment · Fixed by #516
Closed
Assignees
Labels
bug Something isn't working

Comments

@Stezido
Copy link
Contributor

Stezido commented Jul 6, 2020

Description

It should not be possible to revoke "grant permission"-permission from the last user. If so the workflowitem is kind of dead. The only way to resolve such issue is to use the root user. The root user shouldn't be used in any case except creating the first user.

Solution

Edit the revoke permission endpoint of the api so revoking the last user isn't possible anymore.
Check project, subproject and workflowitem and disallow it for both api and ui.

@Stezido
Copy link
Contributor Author

Stezido commented Jul 15, 2020

The described business logic was added to the api.
The ui should prevent a user revoking a permission from him/herself. A prop was missing which leads to the bug that a user could revoke a permission from him/herself on workflowitem level. E2E-tests were added on all levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants