Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Reject Workflowitem #845

Closed
5 tasks
georgimld opened this issue Jun 21, 2021 · 1 comment · Fixed by #929
Closed
5 tasks

Add Option to Reject Workflowitem #845

georgimld opened this issue Jun 21, 2021 · 1 comment · Fixed by #929
Assignees
Labels
api Indicates api related issue or feature feature Indicates a new feature implementation wontfix This will not be worked on

Comments

@georgimld
Copy link
Collaborator

georgimld commented Jun 21, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Currently workflowitems can only be closed, which implies that the workflowitem was approved and the budget is added to the system. Currently, if a workflowitem is not approved it just stays open. A feature to close a workflowitem with a rejection it is needed. Additionaly, an option to add a comment (=exaplanation) when rejecting a workflowitem is needed.

Possible solutions

  • Adapt the "workflowitem_close" endpoint to also pass a reject/approve flag to it
  • Add a new endpoint

TODOs:

  • ui: close workflowitem: open a dialog, user decides if they close the dialog by approving or by rejecting it. When reject is chosen the user must also add a comment
  • api: adapt workflowitem_close endpoint: add flag to approve/reject while closing (default should be approve -> backwards compatibility), add comment field to rejection (optional, only mandatory when rejecting)
  • unit tests
  • e2e-tests
@issuelabeler issuelabeler bot added duplicate Indicates similar issues, pull requests, or discussions feature Indicates a new feature implementation labels Jun 21, 2021
@georgimld georgimld removed the duplicate Indicates similar issues, pull requests, or discussions label Jun 21, 2021
@daniel-arnauer daniel-arnauer added this to the Trubudget 1.23.0 milestone Jun 21, 2021
@daniel-arnauer daniel-arnauer self-assigned this Jun 21, 2021
@issuelabeler issuelabeler bot added api Indicates api related issue or feature duplicate Indicates similar issues, pull requests, or discussions labels Jun 23, 2021
@mayrmartin mayrmartin removed the duplicate Indicates similar issues, pull requests, or discussions label Jun 28, 2021
@stale
Copy link

stale bot commented Jul 31, 2021

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 31, 2021
@stale stale bot closed this as completed Aug 7, 2021
@openkfw openkfw locked and limited conversation to collaborators Aug 9, 2021
@Stezido Stezido removed this from the Technical Backlog milestone May 3, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
api Indicates api related issue or feature feature Indicates a new feature implementation wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants