Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate safeMath operations by using Solidity compiler 0.8.0 #110

Closed
Ro5s opened this issue Dec 29, 2020 · 1 comment
Closed

Deprecate safeMath operations by using Solidity compiler 0.8.0 #110

Ro5s opened this issue Dec 29, 2020 · 1 comment

Comments

@Ro5s
Copy link
Contributor

Ro5s commented Dec 29, 2020

The most recent implementation of Solidity lang (0.8.0) includes default under-over-flow checks for arithmetic operations. This therefore deprecates the use of the SafeMath library and improves code legibility ("+" will usually be more familiar than ".add()").

There can be increased gas costs however, such as the needless checks on for loops as noted by Nick Mudge.

I wanted to flag this potential improvement earlier on, as this could inform syntax of adapter development going forward.

@adridadou
Copy link
Member

@craigwblake is looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants