Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked ground corridors for polygon outline #593

Closed
ediebold opened this issue May 29, 2018 · 4 comments
Closed

Stacked ground corridors for polygon outline #593

ediebold opened this issue May 29, 2018 · 4 comments

Comments

@ediebold
Copy link
Contributor

The stacked ground corridors work great for polylines, but aren't implemented for polygon outlines. It'd be great if we could get this implemented in the same way.

@gberaudo
Copy link
Member

Yes I guess it is possible to take all rings of a grounded polygon and create stacked ground corridors from them. PR welcome.

@ediebold
Copy link
Contributor Author

ediebold commented Jun 2, 2018

Thanks. I'd had a quick look, but was scared off by the different structure of the polygon conversion code. I really need it though, so once I can get my issues in #594 fixed I'll give it a go.

@ediebold
Copy link
Contributor Author

I was about to try and do this, but it looks like the next version of Cesium is going to include support for polylines on terrain: CesiumGS/cesium#6615

With that in mind, it probably makes more sense to wait for the next Cesium release and simply replace the stacked corridor code with support for the native polylines on terrain. After doing that, it shouldn't be too hard to use the same system for the polygon outlines.

So once the next Cesium release is out, I'll get to work on a PR for this.

@gberaudo
Copy link
Member

Yes, will be pretty cool to have this long awaited feature upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants