Confusining naming leading to confusion

[makeclean]

So, weight window generators.....

So, weight window generators can contain many instances of weight windows, makes sense, however....

The root XML object is

<weight_window_generators></weight_window_generators

Maybe a better name here would be weight_windows_generators?

Logical smooth sailing, no issues here, it can contain many weight window generators, which is referred to in the C++ as a 'WeightWindowsGenerator' which has the XML element

<weight_windows_generator></weight_windows_generator>

Good, all clear except, the documentation says Creates a 'weight_window_generator' element to be written to a\ n XML file. , ok no issue, looks like maybe just a typo? Except, the python object which constructs it, is a WeightWindowGenerator.

So maybe, there should be a unification of;

WeightWindowGenerators -> WeightWindowsGenerators
WeightWindowsGenerator -> WeightWindowGenerator

Am I having a senior moment?

[pshriwise]

Agreed, it would be more clear if those names were consistent. I'd probably prefer WeightWindowGenerators/WeightWindowGenerator