Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Spring boot 3.3 migration recipe downgrades Jakarta Servlet to 5 for Jetty 12 #637

Open
santoshdahal12 opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@santoshdahal12
Copy link

santoshdahal12 commented Nov 22, 2024

What version of OpenRewrite are you using?

I am using

  • OpenRewrite maven-plugin 5.45.1 (latest)
  • Maven/Gradle plugin maven 3.9.9

How are you running OpenRewrite?

I am using the Mavencli

mvn -U org.openrewrite.maven:rewrite-maven-plugin:5.45.1:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-spring:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.spring.boot3.UpgradeSpringBoot_3_3 -Drewrite.exportDatatables=true

What is the smallest, simplest way to reproduce the problem?

Run the above recipe in any spring boot 3.3.x project that uses Jetty 12 as embedded server.

What did you expect to see?

It should not add property jakarta-servlet.version 5.0.0 in maven properties section

What did you see instead?

Below property is added even if jetty 12 is in classpath

<jakarta-servlet.version> 5.0.0 </jakarta-servlet.version>

What is the full stack trace of any errors you encountered?

No error, but this property should not be added as there is no need of this property from Spring Boot 3.2 onwards as it supports Jetty 12.

Are you interested in contributing a fix to OpenRewrite?

Yes if the solutiion sounds good. My solution is to drop this recipe from Spring boot 3.2 onwards as there is no need to downgrade.

@santoshdahal12 santoshdahal12 added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant