Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpath 'nodes from anywhere' + attribute selection does not work #4528

Closed
crankydillo opened this issue Sep 26, 2024 · 2 comments
Closed

Xpath 'nodes from anywhere' + attribute selection does not work #4528

crankydillo opened this issue Sep 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@crankydillo
Copy link
Contributor

What version of OpenRewrite are you using?

main branch

How are you running OpenRewrite?

The following test fails on the last assertThat when added to XPathMatcherTest

    @Test
    void noMatterWhereAttributeSelection() {
        assertThat(match("/dependencies/dependency/artifactId[@scope='compile']", xmlDoc)).isTrue();
        assertThat(match("//artifactId[@scope='compile']", xmlDoc)).isTrue();
        assertThat(match("//dependency/artifactId[@scope='compile']", xmlDoc)).isTrue();
    }

Are you interested in contributing a fix to OpenRewrite?

I always want to, but time is short:( #4269 is currently more concerning for us:)

@crankydillo crankydillo added the bug Something isn't working label Sep 26, 2024
@DidierLoiseau
Copy link
Contributor

DidierLoiseau commented Oct 6, 2024

@timtebeek
Copy link
Contributor

Thanks again @DidierLoiseau !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants