Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorator issue with keyword arguments #17

Closed
sepandhaghighi opened this issue Jun 17, 2023 · 1 comment · Fixed by #25
Closed

Decorator issue with keyword arguments #17

sepandhaghighi opened this issue Jun 17, 2023 · 1 comment · Fixed by #25
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sepandhaghighi
Copy link
Member

Description

Decorators cannot handle keyword arguments

Steps/Code to Reproduce

>>> from nava import play
>>> play(sound_path="alarm.wav")

Expected Behavior

Play sound

Actual Behavior

Traceback (most recent call last):
    ...
IndexError: tuple index out of range

Operating System

Windows 10

Python Version

Python 3.8

nava Version (Use : nava.__version__)

Nava 0.1

@sepandhaghighi sepandhaghighi added the bug Something isn't working label Jun 17, 2023
@sadrasabouri sadrasabouri added this to the nava v0.2 milestone Jun 17, 2023
@sadrasabouri
Copy link
Member

Hey @AHReccese
Since we handled the decorator manipulating args only, keyword arguments' use-cases are not covered now. I have assigned you to this issue to handle it anytime you can before nava v0.2 release.
Please let us know if you are not free for this task so that I would re-assign it.

@sadrasabouri sadrasabouri mentioned this issue Jul 9, 2023
@sadrasabouri sadrasabouri linked a pull request Jul 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants