From 53a9f081bcc6e18c337165beffaa1dbbd5928014 Mon Sep 17 00:00:00 2001 From: "Daniel (dB.) Doubrovkine" Date: Thu, 1 Dec 2022 16:44:41 -0500 Subject: [PATCH] Remove DCO workflow in favor of DCO app. (#112) Signed-off-by: Daniel (dB.) Doubrovkine --- CONTRIBUTING.md | 8 ++++++-- RESPONSIBILITIES.md | 5 ----- workflow/dco.yml | 18 ------------------ 3 files changed, 6 insertions(+), 25 deletions(-) delete mode 100644 workflow/dco.yml diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2a5375cdc45..69bf0f58a4a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -82,7 +82,9 @@ By making a contribution to this project, I certify that: involved. ``` -We require that every contribution to OpenSearch is signed with a Developer Certificate of Origin. Additionally, please use your real name. We do not accept anonymous contributors nor those utilizing pseudonyms. +We require that every contribution to OpenSearch is signed with a Developer Certificate of Origin. DCO checks are enabled via a [DCO workflow app](https://github.com/apps/dco) across the entire opensearch-project organization, and your PR will fail CI without it. + +Additionally, we kindly ask you to use your real name. We do not accept anonymous contributors, nor those utilizing pseudonyms. Each commit must include a DCO which looks like this @@ -90,7 +92,9 @@ Each commit must include a DCO which looks like this Signed-off-by: Jane Smith ``` -You may type this line on your own when writing your commit messages. However, if your user.name and user.email are set in your git configs, you can use `-s` or `– – signoff` to add the `Signed-off-by` line to the end of the commit message. +You may type this line on your own when writing your commit messages. However, if your `user.name` and `user.email` are set in your `git config`, you can use `-s` or `––signoff` to add the `Signed-off-by` line to the end of the commit message automatically. + +Forgot to add DCO to a commit? Amend it with `git commit --amend -s`. ## License Headers diff --git a/RESPONSIBILITIES.md b/RESPONSIBILITIES.md index 2117fcf6b5d..afcb24c4897 100644 --- a/RESPONSIBILITIES.md +++ b/RESPONSIBILITIES.md @@ -9,7 +9,6 @@ - [Maintain Overall Health of the Repo](#maintain-overall-health-of-the-repo) - [Manage Roadmap](#manage-roadmap) - [Add Continuous Integration Checks](#add-continuous-integration-checks) - - [Developer Certificate of Origin Workflow](#developer-certificate-of-origin-workflow) - [Use Semver](#use-semver) - [Release Frequently](#release-frequently) - [Promote Other Maintainers](#promote-other-maintainers) @@ -73,10 +72,6 @@ Ensure the repo highlights features that should be elevated to the project roadm Add integration checks that validate pull requests and pushes to ease the burden on Pull Request reviewers. -#### Developer Certificate of Origin Workflow - -Validates pull requests commits are all signed with DCO, [dco.yml](./workflow/dco.yml). Example [pull request](https://github.com/opensearch-project/opensearch-ci/pull/16). - ### Use Semver Use and enforce [semantic versioning](https://semver.org/) and do not let breaking changes be made outside of major releases. diff --git a/workflow/dco.yml b/workflow/dco.yml deleted file mode 100644 index d4c9ff2c486..00000000000 --- a/workflow/dco.yml +++ /dev/null @@ -1,18 +0,0 @@ -name: Developer Certificate of Origin Check - -on: [pull_request] - -jobs: - check: - runs-on: ubuntu-latest - - steps: - - name: Get PR Commits - id: 'get-pr-commits' - uses: tim-actions/get-pr-commits@v1.1.0 - with: - token: ${{ secrets.GITHUB_TOKEN }} - - name: DCO Check - uses: tim-actions/dco@v1.1.0 - with: - commits: ${{ steps.get-pr-commits.outputs.commits }} \ No newline at end of file