Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis Builder] Audit embeddable implementation, edge cases, testing for feature parity #1922

Open
3 tasks done
joshuarrrr opened this issue Jul 20, 2022 · 1 comment
Open
3 tasks done

[Vis Builder] Audit embeddable implementation, edge cases, testing for feature parity #1922

joshuarrrr opened this issue Jul 20, 2022 · 1 comment
Labels
vis builder

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jul 20, 2022 •
edited by ashwin-pc
Loading

Before drag and drop can "graduate" from an experimental feature, we should re-assess some of the implementation and make sure we have true feature parity with existing visualizations.

  • Audit D&D embeddable/embeddable factory implementation and features against visualizations
  • Validate edit/view access controls
  • Validate all sad paths for panel rendering (error states, experimental disabled states, etc.)
@joshuarrrr joshuarrrr mentioned this issue Jul 20, 2022
Closed
12 tasks
@joshuarrrr joshuarrrr changed the title Add proper loading and error panel states [D&D] Add proper loading and error panel states Jul 20, 2022
@joshuarrrr joshuarrrr assigned joshuarrrr and unassigned joshuarrrr Jul 25, 2022
@joshuarrrr joshuarrrr changed the title [D&D] Add proper loading and error panel states [D&D] Audit embeddable implementaion, edge cases, testing for feature parity Jul 29, 2022
@joshuarrrr joshuarrrr changed the title [D&D] Audit embeddable implementaion, edge cases, testing for feature parity [D&D] Audit embeddable implementation, edge cases, testing for feature parity Jul 29, 2022
@joshuarrrr joshuarrrr mentioned this issue Jul 29, 2022
Merged
7 tasks
@ashwin-pc
Copy link
Member

@joshuarrrr When are we targeting this?

@joshuarrrr joshuarrrr changed the title [D&D] Audit embeddable implementation, edge cases, testing for feature parity [Vis Builder] Audit embeddable implementation, edge cases, testing for feature parity Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
vis builder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuarrrr @ashwin-pc