Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling livereload or hotload feature in opensearch-dashboard project #2564

Closed
ghost opened this issue Oct 13, 2022 · 3 comments
Closed

Enabling livereload or hotload feature in opensearch-dashboard project #2564

ghost opened this issue Oct 13, 2022 · 3 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request help wanted Community development is encouraged

Comments

@ghost
Copy link

ghost commented Oct 13, 2022

Is your feature request related to a problem? Please describe.
No

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I’m working on ISM plugin and find it annoying to reload page while making some changes to FE code. Can we add a new option when start the webpack server to enable the livereload and hotload feature, which will help to improve the efficiency alot

Describe the solution you'd like
Use yarn start --hotload --live-reload to enable both features.

A clear and concise description of what you want to happen.
Dashboard and other plugins will leverage the dev-friendly feature.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@ghost ghost added the enhancement New feature or request label Oct 13, 2022
@ananzh ananzh added help wanted Community development is encouraged needs research and removed untriaged labels Oct 18, 2022
@ananzh
Copy link
Member

ananzh commented Oct 18, 2022

I think we need to understand what we want to implement here: hotload or live-reload or both.
what are the benefits and what are the implement plans.
need some community help.

@ashwin-pc ashwin-pc added duplicate This issue or pull request already exists and removed needs research labels Oct 18, 2022
@ashwin-pc
Copy link
Member

The difference is outlined well here: https://stackoverflow.com/a/41429055

This is also a duplicate of #679. Marking it as such and adding these details to the original issue

@ashwin-pc ashwin-pc closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2022
@SuZhou-Joe
Copy link
Member

Thanks and I think it should be both enabled and let user choose which to use by cli options. Anyway I find a duplicate one and will try to raise a PR once I figure it out in dashboards repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request help wanted Community development is encouraged
Projects
None yet
Development

No branches or pull requests

4 participants