Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change console plugin to use core.http to replace jQuery.ajax #3044

Closed
zengyan-amazon opened this issue Dec 7, 2022 · 2 comments
Closed

change console plugin to use core.http to replace jQuery.ajax #3044

zengyan-amazon opened this issue Dec 7, 2022 · 2 comments
Labels
enhancement New feature or request technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@zengyan-amazon
Copy link
Member

Is your feature request related to a problem? Please describe.
OSD DevTool console browser side plugin uses jQuery.ajax to call NodeJS API instead of using core.http which is inconsistent with all other use cases, all settings on browser side core.http, like request interceptors don't apply to the devtool console calls. related code: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/console/public/lib/opensearch/opensearch.ts#L61

Describe the solution you'd like
refactor console plugin to use core.http to call OSD server, get rid of

Describe alternatives you've considered
N/A

Additional context
N/A
@zengyan-amazon zengyan-amazon added the enhancement New feature or request label Dec 7, 2022
@seanneumann
Copy link
Contributor

Thanks @zengyan-amazon. This seems like a generally good change. Looking forward to seeing the PR.

@joshuarrrr
Copy link
Member

That definitely sounds like a legacy oversight. Is it just tech debt, or is there any user impact of using the ajax approach?

@joshuarrrr joshuarrrr added the technical debt If not paid, jeapardizes long-term success and maintainability of the repository. label Dec 8, 2022
@zengyan-amazon zengyan-amazon mentioned this issue Dec 14, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanneumann @joshuarrrr @zengyan-amazon