Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React version 16.14.0 have reached it's EOL and require upgrade #3275

Open
shubher13 opened this issue Jan 13, 2023 · 4 comments
Open

React version 16.14.0 have reached it's EOL and require upgrade #3275

shubher13 opened this issue Jan 13, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file help wanted Community development is encouraged v3.0.0

Comments

@shubher13
Copy link

we build custom plugins for OpenSearch-Dashboard which uses react version >=17, so while building the plugin with dashboard running with react version 16, it fails with conflicting dependencies.

So please let me know if there is a way to build the plugin with react^17 on osd running with react^16.

@ashwin-pc
Copy link
Member

@shubher13 EOL is a little bit of a misnomer for react based on their versioning policy https://reactjs.org/docs/faq-versioning.html. that being said for your usecases react 16 is a valid blocker. I don't know if we have investigated the effort in migrating react to any of the newer versions but it should not be too difficult since react has a very clear migration path for it's versions. The bigger challenge however is that react 16 is a hard dependency for plugins based on our existing architecture. Changing that would be a breaking change and require a major release right now.

Can you tell me what react features you need for your plugin?

@manasvinibs manasvinibs added dependencies Pull requests that update a dependency file and removed untriaged labels Jan 17, 2023
@joshuarrrr
Copy link
Member

@shubher13 Is this still an issue that's blocking you?

@joshuarrrr joshuarrrr removed their assignment Apr 11, 2023
@joshuarrrr joshuarrrr added the help wanted Community development is encouraged label Apr 11, 2023
@joshuarrrr
Copy link
Member

My understanding is that upgrading to React 18 is blocked by #1118. On the other hand, upgrading to React 17 would be fairly straightforward. But because it's a breaking change, it's probably worth going all the way to 18 anyway.

Resources for upgrading to React 17:

@shubher13
Copy link
Author

My understanding is that upgrading to React 18 is blocked by #1118. On the other hand, upgrading to React 17 would be fairly straightforward. But because it's a breaking change, it's probably worth going all the way to 18 anyway.

Resources for upgrading to React 17:

@joshuarrrr, As node v17 has already reached it's EOL so now it would be worth considering node v18 for the upgrade. Do you have any insights regarding the anticipated timeframe for this upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Community development is encouraged v3.0.0
Projects
None yet
Development

No branches or pull requests

4 participants