Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[De-Angular] Clean angular context in opensearch_dashboards_legacy #5019

Closed
3 tasks
ananzh opened this issue Sep 14, 2023 · 0 comments
Closed
3 tasks

[De-Angular] Clean angular context in opensearch_dashboards_legacy #5019

ananzh opened this issue Sep 14, 2023 · 0 comments
Labels
de-angular de-angularize work v2.11.0

Comments

@ananzh
Copy link
Member

ananzh commented Sep 14, 2023

I think there are couple of things we could do for this package. We also want to evaluate the impacts. Here are some reference action items, and please double check:

  • Remove src/plugins/opensearch_dashboards_legacy/public/paginate completely.
    This paginate is only for angular. Specifically, it's defining two AngularJS directives: PaginateDirectiveProvider and PaginateControlsDirectiveProvider. The PaginateDirectiveProvider seems to provide pagination functionality for a list, while PaginateControlsDirectiveProvider provides the UI for controlling the pagination. We don't need them any more and we also should clean paginate from src/plugins/opensearch_dashboards_legacy/public/index.ts.

  • Clean out src/plugins/opensearch_dashboards_legacy/public/notify

  • Remove src/plugins/opensearch_dashboards_legacy/public/notify/lib/format_angular_http_error.ts
  • Remove src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts
  • Clean src/plugins/opensearch_dashboards_legacy/public/notify/lib/index.ts
  • Clean out src/plugins/opensearch_dashboards_legacy/public/utils
  • Remove src/plugins/opensearch_dashboards_legacy/public/utils/system_api.ts
  • Remove src/plugins/opensearch_dashboards_legacy/public/utils/register_listen_event_listener.js
  • Remove src/plugins/opensearch_dashboards_legacy/public/utils/private.js
  • Remove src/plugins/opensearch_dashboards_legacy/public/utils/private.d.ts
  • Remove src/plugins/opensearch_dashboards_legacy/public/utils/osd_accessible_click.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
de-angular de-angularize work v2.11.0
Projects
None yet
Development

No branches or pull requests

2 participants