-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide/Show authentication method in multi data source plugin based on configuration #5694
Comments
in addition to hide/show authentication methods, we only support basic auth(username/password) and static IAM credentials authentication methods. We may consider to make it easier for developers to add other auth methods via plugin, e.g. supporting API key etc. |
Right now we are supporting No Authentication, Basic Authentication(username/password) and AWS SigV4 (static IAM credentials) authentication methods. Although we propose to add interface in multi data source plugin to register authentication method by plugin in #5692, it would be too many plugins if we decide to move each authentication method in plugins. That's why I feel we should keep existing auth methods as part of core code and provide config options to manage them (hid/show). I'll mark this issue as follow up item in #5692 |
Please feel free to optimize/modify as per your preference
|
@xinruiba Can you take a look at this and help? Thanks! |
@bandinib-amzn Sure, happy to work on it. |
The readOnly prop is not works as expected in Would you mind to help us understand the expected behavior when readOnly prop is set to true? @kgcreative Since readOnly is not works, we decide to move forward with the "disabled" prop: |
This one get completed in PR #5976. We should be able to mark it as complete. @bandinib-amzn . Thanks |
Is your feature request related to a problem? Please describe.
Yes, I wanted to customize authentication methods in multi data source plugin. Sometime I don't need particular auth method to be supported in multi data source plugin because of security or any other concern. I should have flexibility to show only authentication method which I wanted.
Also if there is only one option for selection, make dropdown or selection option read only.
Describe the solution you'd like
Add configuration in yml file and hide/show the auth options based on configuration.
The text was updated successfully, but these errors were encountered: