-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] Data source picker should have same behavior in devtool, tutorial, etc where it is used #5717
Comments
Happy to work on it |
Does that mean all occurrences of |
Adding here some feedback I received from UX team while reviewing these pages:
|
Yeah, you are right, it should be
At of today, in my understanding, local cluster has to be present unless #5696 is introduced
I can consult UX about this component, my feeling is it is too busy to show a label inside the picker where we already know we are looking for datasource instead of any other objects.
This behavior doesn't exist yet until local cluster can be removed, and agree that the behavior should be the same, and we can decide later if the behavior should be implemented in the picker |
Is your feature request related to a problem? Please describe.
I feel confused when seeing different behavior for the data source picker based on where it is located
Describe the solution you'd like
The datasource picker should be one component to ensure the behavior is the same. Then, if we need to change the behavior for the picker, we don't need to go through entire code base to find the duplicated code in order to make change. The component should be reusable by other plugins
To unify the behavior, the default option for the picker when first opening the page with the picker should be
Local cluster
. After removing the option, it should displaySelect a data source
. Change theDataSource
toData source
Describe alternatives you've considered
Stay where we are and just change every places every time that a small text adjustment is needed for the picker.
Additional context
When data source plugin is enabled, if we go to dev tool page or add sample data page, the behavior of the data source picker is different:
dev tools shows
Select a data source
and the prepend isData source
add sample data tutorial shows a default value and the prepend is
DataSource
after removing the default value it shows
Select a Data Source
The text was updated successfully, but these errors were encountered: