Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD]Change how dev tool/saved object/sample data consumes data source selector to use datasourcemanangement.ui.DataSourceSelector #6369

Closed
2 of 3 tasks
zhongnansu opened this issue Apr 8, 2024 · 3 comments · Fixed by #6477
Assignees
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.14.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Apr 8, 2024

Currently, data source selector is consumed by 3 internal plugins, by import { DataSourceSelector } from data_source_management/public'. We need to update it to consume by calling datasourcemanangement.ui.DataSourceSelector, so that behavior of default datasource render, as well as hide/show local cluster could be consistent across everywhere.

  • 1. dev tool console
  • 2. saved object management (import feature)
  • 3. sample data (home plugin)
@zhongnansu zhongnansu added the enhancement New feature or request label Apr 8, 2024
@zhongnansu zhongnansu self-assigned this Apr 8, 2024
@zhongnansu zhongnansu added multiple datasource multiple datasource project v2.14.0 labels Apr 8, 2024
@zhongnansu
Copy link
Member Author

I'd like to work on this issue.

@zhongnansu
Copy link
Member Author

for home plugin, currently there's no better way to add dataSourceManagement as an optional plugin, because it creates circular dependency.

home -> dataSourceManagement -> management -> home

cc: @BionIT

@BionIT
Copy link
Collaborator

BionIT commented Apr 22, 2024

Instead of adding datasourcemanagement as optional plugin, can we simply use the createDataSourceSelector function

@BionIT BionIT closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project v2.14.0
Projects
Status: Planned work items
2 participants