Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual] [Backport 2.x] Automates chromedriver version selection for tests (#2990) #3125

Merged

Conversation

joshuarrrr
Copy link
Member

backport a26fb43 from #2990

@joshuarrrr joshuarrrr requested a review from a team as a code owner December 22, 2022 22:15
@joshuarrrr joshuarrrr force-pushed the backport/backport-2990-to-2.x branch from 8de7c90 to efeba57 Compare December 22, 2022 22:15
ashwin-pc
ashwin-pc previously approved these changes Dec 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #3125 (1a1cb8e) into 2.x (0a92e60) will decrease coverage by 0.07%.
The diff coverage is 50.49%.

@@            Coverage Diff             @@
##              2.x    #3125      +/-   ##
==========================================
- Coverage   66.67%   66.59%   -0.08%     
==========================================
  Files        3219     3219              
  Lines       61450    61531      +81     
  Branches     9417     9431      +14     
==========================================
+ Hits        40971    40978       +7     
- Misses      18232    18308      +76     
+ Partials     2247     2245       -2     
Flag Coverage Δ
Linux 66.59% <50.49%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/plugins/data_source/server/client/client_pool.ts 58.82% <ø> (ø)
src/plugins/vis_builder/public/application/app.tsx 12.50% <0.00%> (-20.84%) ⬇️
..._builder/public/application/components/top_nav.tsx 4.54% <0.00%> (-0.46%) ⬇️
...er/public/application/utils/get_top_nav_config.tsx 57.77% <0.00%> (+1.25%) ⬆️
src/plugins/vis_builder/public/plugin.ts 23.40% <14.28%> (-4.19%) ⬇️
...plication/utils/state_management/metadata_slice.ts 38.46% <25.00%> (-7.00%) ⬇️
...gins/data_source/server/client/configure_client.ts 63.63% <31.81%> (-23.55%) ⬇️
.../plugins/data_source/server/data_source_service.ts 71.42% <66.66%> (-3.58%) ⬇️
...ents/edit_data_source/components/header/header.tsx 93.75% <75.00%> (-6.25%) ⬇️
.../data_source_management/public/components/utils.ts 95.83% <75.00%> (-4.17%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

AMoo-Miki
AMoo-Miki previously approved these changes Dec 22, 2022
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh for taking care of this.

…t#2990)

Signed-off-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit a26fb43)
@manasvinibs manasvinibs force-pushed the backport/backport-2990-to-2.x branch from efeba57 to ad391fd Compare January 4, 2023 23:38
@manasvinibs manasvinibs added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 5, 2023
@abbyhu2000 abbyhu2000 dismissed stale reviews from AMoo-Miki and ashwin-pc via ad391fd January 5, 2023 22:15
@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Jan 6, 2023

Not waiting for tests as this has no bearing on them other than installing the correct chromedriver which we know it does. Moreover, all the linux tests are passing.

@AMoo-Miki AMoo-Miki merged commit 99353ea into opensearch-project:2.x Jan 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.0 2.0
# Navigate to the new working tree
pushd ../.worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-3125-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.0
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-3125-to-2.0.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-3125-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-3125-to-2.1.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-3125-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-3125-to-2.2.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-3125-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-3125-to-2.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-3125-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 99353ea0c60bebc60a04845096c13019ac76b78f
# Push it to GitHub
git push --set-upstream origin backport/backport-3125-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-3125-to-2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants