[Manual] [Backport 1.x] Automates chromedriver version selection for tests (#2990) #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-pc
approved these changes
Dec 23, 2022
ashwin-pc
previously requested changes
Dec 23, 2022
AMoo-Miki
requested changes
Jan 18, 2023
There was a problem hiding this comment.
We need to dumb down the code for Node v10; i have made suggestions for the code changes.
That said, we cannot enable Node v10 tests on latest images of any OS because they use latest versions of Chrome and they require latest versions of chromedriver which only work on Node v14+.
One solution would be to have a specific version of Chrome installed on the latest images; there is an Action for that.
8 tasks
Signed-off-by: Miki <miki@amazon.com>
Make `upgrade_chromedriver.js` work on Node v10
manasvinibs
approved these changes
Jan 19, 2023
AMoo-Miki
approved these changes
Jan 19, 2023
|
Merging this with know failures in CI checks related to chromdriver versions. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
…tests (#2990) (#3128) * Automates chromedriver version selection for tests (#2990) Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit a26fb43) Signed-off-by: Josh Romero <rmerqg@amazon.com> * Make `upgrade_chromedriver.js` work on Node v10 Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Miki <miki@amazon.com> (cherry picked from commit 3dab4c0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Jan 24, 2023
…tests (#2990) (#3128) (#3294) * Automates chromedriver version selection for tests (#2990) Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit a26fb43) Signed-off-by: Josh Romero <rmerqg@amazon.com> * Make `upgrade_chromedriver.js` work on Node v10 Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Miki <miki@amazon.com> (cherry picked from commit 3dab4c0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport a26fb43 from #2990
Note that I manually ported the changes from .github/workflows/build_and_test_workflow.yml to .github/workflows/pr_check_workflow.yml