Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE-2022-25851][1.x] Bump jpeg-js from 0.4.1 to 0.4.4 #3741

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Mar 30, 2023

Issue Resolve

#1725

Backport PR

#1753

Description

The package jpeg-js before 0.4.4 is vulnerable to Denial of Service (DoS) where a particular piece of input will cause to enter an infinite loop and never return. In 1.x, we are currently using 0.4.1.

ubuntu@ip-172-31-55-237:~/work/OpenSearch-Dashboards$ yarn why jpeg-js
yarn why v1.22.19
[1/4] Why do we have the module "jpeg-js"...?
[2/4] Initialising dependency graph...
warning Resolution field "typescript@4.0.2" is incompatible with requested version "typescript@~3.7.2"
warning Resolution field "shelljs@0.8.5" is incompatible with requested version "shelljs@^0.6.0"
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "jpeg-js@0.4.1"
info Reasons this module exists
   - "_project_#jimp#@jimp#types#@jimp#jpeg" depends on it
   - Hoisted from "_project_#jimp#@jimp#types#@jimp#jpeg#jpeg-js"
info Disk size without dependencies: "252KB"
info Disk size with unique dependencies: "252KB"
info Disk size with transitive dependencies: "252KB"
info Number of shared dependencies: 0
Done in 1.03s.

There is no breaking change between 0.4.1 and 0.4.4. Just backport this fix PR here to 1.x.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh ananzh added cve Security vulnerabilities detected by Dependabot or Mend backport 1.3 labels Mar 30, 2023
@ananzh ananzh requested a review from joshuarrrr March 30, 2023 17:05
Issue Resolve
opensearch-project#1725

Backport PR
opensearch-project#1753

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
@ananzh ananzh force-pushed the 1.x-bump-jpeg-js branch from fc71d28 to ba2f9ca Compare March 30, 2023 17:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #3741 (27ec0f6) into 1.x (53d2d91) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              1.x    #3741   +/-   ##
=======================================
  Coverage   67.49%   67.50%           
=======================================
  Files        3044     3044           
  Lines       58692    58692           
  Branches     8902     8902           
=======================================
+ Hits        39617    39619    +2     
+ Misses      16926    16925    -1     
+ Partials     2149     2148    -1     
Flag Coverage Δ
Linux 67.45% <ø> (ø)
Windows 67.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ananzh ananzh added the v1.3.9 label Mar 30, 2023
@joshuarrrr joshuarrrr added v1.3.10 and removed v1.3.9 labels Apr 13, 2023
@joshuarrrr joshuarrrr merged commit 637d545 into opensearch-project:1.x Apr 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 17, 2023
Issue Resolve
#1725

Backport PR
#1753

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 637d545)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
abbyhu2000 pushed a commit that referenced this pull request Apr 17, 2023
Issue Resolve
#1725

Backport PR
#1753

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit 637d545)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 cve Security vulnerabilities detected by Dependabot or Mend v1.3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants