From c4bcb2f415c03886c2d4a536c9d50da8c9afb164 Mon Sep 17 00:00:00 2001 From: Aozixuan Priscilla Guan Date: Fri, 14 Apr 2023 10:48:59 -0500 Subject: [PATCH 1/2] Remove unused url Signed-off-by: Aozixuan Priscilla Guan --- .../application/angular/doc_table/create_doc_table_react.tsx | 1 - .../discover/public/application/doc_views/doc_views_helpers.tsx | 1 - 2 files changed, 2 deletions(-) diff --git a/src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx b/src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx index 8997179781d0..8b68dc7ae466 100644 --- a/src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx +++ b/src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx @@ -88,7 +88,6 @@ export function convertDirectiveToRenderFn( return () => { if (!rejected) { // for cleanup - // http://roubenmeschian.com/rubo/?p=51 cleanupFnPromise.then((cleanup) => cleanup()); } }; diff --git a/src/plugins/discover/public/application/doc_views/doc_views_helpers.tsx b/src/plugins/discover/public/application/doc_views/doc_views_helpers.tsx index 3ec87455e837..e113f6961fc3 100644 --- a/src/plugins/discover/public/application/doc_views/doc_views_helpers.tsx +++ b/src/plugins/discover/public/application/doc_views/doc_views_helpers.tsx @@ -98,7 +98,6 @@ export function convertDirectiveToRenderFn( return () => { if (!rejected) { // for cleanup - // http://roubenmeschian.com/rubo/?p=51 cleanupFnPromise.then((cleanup) => cleanup()); } }; From 5b8579e6aa45e5d4947742d226c78966c30595ae Mon Sep 17 00:00:00 2001 From: Aozixuan Priscilla Guan Date: Fri, 14 Apr 2023 11:01:49 -0500 Subject: [PATCH 2/2] Add changelog for the cleanup issue Signed-off-by: Aozixuan Priscilla Guan --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cffeefe569e8..ce2eeef11465 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -117,6 +117,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - [Vega] Add Filter custom label for opensearchDashboardsAddFilter ([#3640](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3640)) - [Timeline] Fix y-axis label color in dark mode ([#3698](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3698)) - [Table Visualization] Fix data table not adjusting height on the initial load ([#3816](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3816)) +- Cleanup unused url ([#3847](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3847)) ### 🚞 Infrastructure