[CI][Cypress][Bug] use default SOURCE inputs for checkout
#5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
requested review from
ananzh,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
kavilla
added
backport 2.x
Skip-Changelog
Codecov Report
@@ Coverage Diff @@
## main #5197 +/- ##
=======================================
Coverage 66.76% 66.76%
=======================================
Files 3278 3278
Lines 62999 62999
Branches 10031 10031
=======================================
Hits 42059 42059
Misses 18473 18473
Partials 2467 2467
Flags with carried forward coverage won't be shown. Click here to find out more. |
opensearch-project#5134 Incorrectly uses the source of the code to pull down to BASE REF, which would likely be `main` or `2.x`, etc. It should be pulling down the PR branch. Cypress tests at the time of merging were failing due to unrelated issue of disk allocation. Not setting the env variables causes the workflow to rely on the default values which is a return back to the original implementation and if the env is set then it will be not empty. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> do not set source env variables Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
kavilla/ci/head_ref
branch
from
331f1aa to
37cbfd3
Compare
kavilla
changed the title
head_refSOURCE inputs for checkout
AMoo-Miki
approved these changes
Oct 4, 2023
ashwin-pc
approved these changes
Oct 4, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
#5134 Incorrectly uses the source of the code to pull down to BASE REF, which would likely be `main` or `2.x`, etc. It should be pulling down the PR branch. Cypress tests at the time of merging were failing due to unrelated issue of disk allocation. Not setting the env variables causes the workflow to rely on the default values which is a return back to the original implementation and if the env is set then it will be not empty. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit dc6a7ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Oct 4, 2023
#5134 Incorrectly uses the source of the code to pull down to BASE REF, which would likely be `main` or `2.x`, etc. It should be pulling down the PR branch. Cypress tests at the time of merging were failing due to unrelated issue of disk allocation. Not setting the env variables causes the workflow to rely on the default values which is a return back to the original implementation and if the env is set then it will be not empty. (cherry picked from commit dc6a7ec) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
willie-hung
pushed a commit
to willie-hung/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2023
opensearch-project#5134 Incorrectly uses the source of the code to pull down to BASE REF, which would likely be `main` or `2.x`, etc. It should be pulling down the PR branch. Cypress tests at the time of merging were failing due to unrelated issue of disk allocation. Not setting the env variables causes the workflow to rely on the default values which is a return back to the original implementation and if the env is set then it will be not empty. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Willie Hung <willie880201044@gmail.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 7, 2023
opensearch-project#5134 Incorrectly uses the source of the code to pull down to BASE REF, which would likely be `main` or `2.x`, etc. It should be pulling down the PR branch. Cypress tests at the time of merging were failing due to unrelated issue of disk allocation. Not setting the env variables causes the workflow to rely on the default values which is a return back to the original implementation and if the env is set then it will be not empty. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5134
Incorrectly uses the source of the code to pull down to BASE REF,
which would likely be
mainor2.x, etc.It should be pulling down the PR branch. Cypress tests at the time
of merging were failing due to unrelated issue of disk allocation.
Not setting the env variables causes the workflow to rely on the default
values which is a return back to the original implementation and if the
env is set then it will be not empty.
Issues Resolved
n/a
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr