Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x] Refactor getClient and getLegacyClient to use authentication method registry (#5881) #5940

Conversation

bandinib-amzn
Copy link
Member

Description

Backport from d56b04 from #5881

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.04%. Comparing base (2431df6) to head (42a90ba).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...gins/data_source/server/client/configure_client.ts 85.71% 0 Missing and 2 partials ⚠️
...ta_source/server/legacy/configure_legacy_client.ts 91.66% 0 Missing and 1 partial ⚠️
...ins/data_source/server/util/credential_provider.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #5940      +/-   ##
==========================================
+ Coverage   67.03%   67.04%   +0.01%     
==========================================
  Files        3303     3305       +2     
  Lines       63626    63655      +29     
  Branches    10149    10157       +8     
==========================================
+ Hits        42653    42679      +26     
- Misses      18508    18510       +2     
- Partials     2465     2466       +1     
Flag Coverage Δ
Linux_1 35.21% <ø> (ø)
Linux_2 55.14% <ø> (ø)
Linux_3 43.63% <88.57%> (+0.05%) ⬆️
Linux_4 35.33% <ø> (ø)
Windows_1 35.24% <ø> (ø)
Windows_2 55.10% <ø> (ø)
Windows_3 43.64% <88.57%> (+0.04%) ⬆️
Windows_4 35.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bandinib-amzn bandinib-amzn force-pushed the backport/backport-5881-to-2.x branch 2 times, most recently from dabc3e1 to ee11f87 Compare February 26, 2024 21:23
ZilongX
ZilongX previously approved these changes Feb 26, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Flyingliuhub
Flyingliuhub previously approved these changes Feb 26, 2024
@bandinib-amzn bandinib-amzn dismissed stale reviews from Flyingliuhub and ZilongX via c5130b9 February 27, 2024 02:57
bandinib-amzn and others added 2 commits February 26, 2024 18:58
…egistry (opensearch-project#5881)

* Refactor getClient and getLegacyClient to use authentication method registry

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

* Adds changelog and UT

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

---------

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit d56b04d)
Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
@bandinib-amzn bandinib-amzn force-pushed the backport/backport-5881-to-2.x branch from c5130b9 to 42a90ba Compare February 27, 2024 02:58
@bandinib-amzn
Copy link
Member Author

Failing cypress test is not related to this change.

@ZilongX ZilongX self-requested a review February 27, 2024 17:41
@bandinib-amzn bandinib-amzn merged commit e59e506 into opensearch-project:2.x Feb 27, 2024
66 of 67 checks passed
@bandinib-amzn bandinib-amzn deleted the backport/backport-5881-to-2.x branch February 27, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants