[OSCI] Removed KUI usage in visualizations -- Completion of Original PR #6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR completes opensearch-project#5462 Please refer to the above PR for more details Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
requested review from
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT and
xinruiba
as code owners
ananzh
added
technical debt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6360 +/- ##
==========================================
- Coverage 67.52% 59.49% -8.03%
==========================================
Files 3378 3050 -328
Lines 65883 58556 -7327
Branches 10659 9206 -1453
==========================================
- Hits 44485 34839 -9646
- Misses 18854 21841 +2987
+ Partials 2544 1876 -668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Apr 7, 2024
AMoo-Miki
approved these changes
Apr 11, 2024
|
Seems a unit test failed, |
|
@SuZhou-Joe thanks for pointing it out. will submit a PR to fix these tests in 5mins |
|
@SuZhou-Joe PR is here #6411 |
7 tasks
ananzh
pushed a commit
that referenced
this pull request
Apr 30, 2024
…PR (#6360) (#6407) This PR completes #5462 Please refer to the above PR for more details Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 46b17e4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes
#5462
Please refer to the above PR for more details
Issues Resolved
Partical #3386
Screenshot
Check List
yarn test:jestyarn test:jest_integration