-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Cluster level setting to restrict replication type in index level settings #11457
Comments
We should allow New indices passing in explicit index.replication.typeNew indices creation using replication.type which mis-matches with cluster level replication type should not be allowed. New indices using Index templates and composbale templatesSimilar to above, new index creations where index attains replication type setting from templates should not be allowed when replication.type setting from template does not match with cluster level setting. New indices via data streams (backup index creation and rollover)Data streams create automatic backup writeable index pulling in settings from index templates. The new index behavior creation should be similar to above. Snapshot restoreSImilar to above, the snapshot restore should not be allowed when restored index has mis-matching setting from cluster level replication type setting. Shrink, Split, CloneSimilar to above, these operations should not be allowed when target index has explicit index replication type setting which does not matches with cluster level. Tagging @dagneyb @elfisher for feedback on above intended behavior. CC @anasalkouz @mch2 |
I agree with the suggestion. I only have a follow up question whether we considered a cluster level setting that can be used to check if override is allowed or not, this way we can ignore index level changes always and it might not be restricted to just replication but used wider for better cluster control. like - cluster.indices.replication.allowoverride or something of the likes. |
Thanks @rohin for the feedback. I really like the idea of having a unique cluster level setting that governs index level overrides are allowed or not. On thinking more on this proposal, I see below challenges.
What are your thoughts on this ? |
Closing this issue as change has been implemented. |
Summary
Today, we have
cluster.indices.replication.strategy
cluster setting that sets the default replication type for any index in the cluster which can be overridden by index level settings i.e.index.replication.type
value. As part of this change, we need to ensure the cluster level settings are not overridden by index level settings. This will be useful for admins to provide a more strict control on index replication type where they set cluster level replication type usingcluster.indices.replication.strategy
settings and allows users/consumers to create their indices. We attempted this previously but it has a bug where snapshot restore functionality was broken. Proposed new setting name iscluster.index.restrict.replication.type
.Describe the solution you'd like
Introduce a new cluster setting would help enforce a replication strategy and prevent override by the index level settings. The new settings will be
opt-in
which means it willfalse
by default.Related
The text was updated successfully, but these errors were encountered: