Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiered Caching][Milestone 1] Refactor Tiered caching interfaces #12296

Closed
sgup432 opened this issue Feb 12, 2024 · 4 comments
Closed

[Tiered Caching][Milestone 1] Refactor Tiered caching interfaces #12296

sgup432 opened this issue Feb 12, 2024 · 4 comments
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance v2.13.0 Issues and PRs related to version 2.13.0

Comments

@sgup432
Copy link
Contributor

sgup432 commented Feb 12, 2024

Is your feature request related to a problem? Please describe

As part of initial Tiered caching framework, we had exposed StoreAwareCache(link) and tiered spillover cache framework(link) which has all the logic to spill evicted items to the disk tier.

While reviewing further changes here and elsewhere, we discussed whether StoreAwareCache is really needed as it exposes cacheStoreType which shouldn't be needed to the consumer. And also ideally tieredSpilloverCache should be moved to a module as it is optional and not required to be within OpenSearch core. Considering we are now also maintaining cache stats within cache itself(link) instead of using a listener based approach, all this required following changes as mentioned below.

Describe the solution you'd like

So as part of this issue we will refactor following:

  • Move TieredSpilloverCache to a module
  • Remove StoreAwareCache interface and not expose CacheStoreType in core.
  • Remove listener for hits/misses/evictions
  • Provide a way for any type of cache(IndicesRequestCache for example) to initialize any kind of ICache via setting based mechanism.

Related component

Search:Performance

Describe alternatives you've considered

No response

Additional context

No response

@sgup432 sgup432 added enhancement Enhancement or improvement to existing feature or request untriaged labels Feb 12, 2024
@sgup432
Copy link
Contributor Author

sgup432 commented Feb 12, 2024

@msfroh

@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7 8]
@sgup432 Thanks for opening up this issue for follow up, looking forward to these improvements.

@stephen-crawford
Copy link
Contributor

@opensearch-project/opensearch-core I believe this can be closed.

@getsaurabh02
Copy link
Member

@sgup432 should we close this out?

@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Search Project Board Aug 15, 2024
@sgup432 sgup432 closed this as completed Oct 2, 2024
@github-project-automation github-project-automation bot moved this from Later (6 months plus) to ✅ Done in Search Project Board Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Performance v2.13.0 Issues and PRs related to version 2.13.0
Projects
Archived in project
Status: Planned work items
Development

No branches or pull requests

5 participants