Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all handling of index.mapper.dynamic #12416

Closed
peternied opened this issue Feb 21, 2024 · 4 comments · Fixed by #13067
Closed

Remove all handling of index.mapper.dynamic #12416

peternied opened this issue Feb 21, 2024 · 4 comments · Fixed by #13067
Assignees
Labels
bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0

Comments

@peternied
Copy link
Member

peternied commented Feb 21, 2024

Description

index.mapper.dynamic's deprecation predates OpenSearch. We should remove any traces of this legacy setting from the system except to warn that the setting won't be actioned on.

The INDEX_MAPPER_DYNAMIC_SETTING should be ignored, it won't be, org.opensearch.action.support.AutoCreateIndex:

    public AutoCreateIndex(
        Settings settings,
        ClusterSettings clusterSettings,
        IndexNameExpressionResolver resolver,
        SystemIndices systemIndices
    ) {
        this.resolver = resolver;
        dynamicMappingDisabled = !MapperService.INDEX_MAPPER_DYNAMIC_SETTING.get(settings);
        this.systemIndices = systemIndices;
        this.autoCreate = AUTO_CREATE_INDEX_SETTING.get(settings);
        clusterSettings.addSettingsUpdateConsumer(AUTO_CREATE_INDEX_SETTING, this::setAutoCreate);
    }

Expected Result

Remove this legacy settings usage expect for purposes of warning about its removal and non-functionality.

@peternied peternied self-assigned this Feb 21, 2024
@peternied peternied changed the title Resolve handling of index.mapper.dynamic Remove all handling of index.mapper.dynamic Feb 21, 2024
@peternied peternied added bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing and removed untriaged labels Feb 21, 2024
@peternied
Copy link
Member Author

[Triage - attendees 1 2 3 4 5]
Thanks for creating this issue

@andrross
Copy link
Member

@peternied We need to fix this ASAP now that #11193 allows for indices to be created with this deprecated setting present, right?

@reta
Copy link
Collaborator

reta commented Feb 21, 2024

@peternied We need to fix this ASAP now that #11193 allows for indices to be created with this deprecated setting present, right?

So we need to check the indexVersionCreated and if the version is on or after V_2_0_0, we should reject index creation, the same we have to do for 2.x backport but lower the version to ~1.1.0 since we do not expect any indices created by OpenSearch to have this setting).

@peternied peternied added the v2.13.0 Issues and PRs related to version 2.13.0 label Feb 21, 2024
@peternied
Copy link
Member Author

We need to fix this ASAP

This change was merged into 2.x, so it needs to target 2.13. I'll work on this soon and want to be clear no 2.12.1 change is needed.

@reta reta added v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0 and removed v2.13.0 Issues and PRs related to version 2.13.0 labels Apr 4, 2024
@reta reta added v2.15.0 Issues and PRs related to version 2.15.0 and removed v2.14.0 labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants