Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Tiered Caching] Fix test testComputeIfAbsentWithFactoryBasedCacheCreation #12699

Closed
sgup432 opened this issue Mar 16, 2024 · 0 comments · Fixed by #12700
Closed

[BUG][Tiered Caching] Fix test testComputeIfAbsentWithFactoryBasedCacheCreation #12699

sgup432 opened this issue Mar 16, 2024 · 0 comments · Fixed by #12700
Labels

Comments

@sgup432
Copy link
Contributor

sgup432 commented Mar 16, 2024

Describe the bug

Currently the unit test TieredSpilloverCacheTests.testComputeIfAbsentWithFactoryBasedCacheCreation passes but the onHeap cache size is always zero in this case as we are not adding appropriate settings/feature flag

Related component

Search:Performance

To Reproduce

Check fortieredSpilloverCache.getOnHeapCache().count() > 0 in the end of test. Test would fail where it shouldn't ideally.

Expected behavior

OnHeap cache tier size should > 0 for testComputeIfAbsentWithFactoryBasedCacheCreation

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant