Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FastFilterRewriteHelper #14435

Closed
bowenlan-amzn opened this issue Jun 18, 2024 · 0 comments · Fixed by #14464
Closed

Refactor FastFilterRewriteHelper #14435

bowenlan-amzn opened this issue Jun 18, 2024 · 0 comments · Fixed by #14464

Comments

@bowenlan-amzn
Copy link
Member

bowenlan-amzn commented Jun 18, 2024

As we apply the optimization to more aggregator like #13531 and upcoming #14189. The helper class now becomes huge.

Also the logics of performing the optimization requires refactoring, more details from these comments
#13865 (comment)
#13865 (comment)
#13865 (comment)
#13865 (comment)
#13865 (comment)

AggregationType is to provide Helper access to some fields of aggregator.
Now the Rewriteable check and init AggregationType is a bit intertwined, better to refactor to segregate them.
The logic flow in aggregator would be

  • init context object with rewriteable flag as false
  • check if rewriteable
  • build ranges with aggregator providing any needed fields

Can also see if we are able to refactor the term aggregation optimization easily into one path

@bowenlan-amzn bowenlan-amzn self-assigned this Jun 18, 2024
@bowenlan-amzn bowenlan-amzn converted this from a draft issue Jun 18, 2024
@bowenlan-amzn bowenlan-amzn added v2.16.0 Issues and PRs related to version 2.16.0 and removed untriaged labels Jun 18, 2024
@bowenlan-amzn bowenlan-amzn moved this from Now (This Quarter) to In Progress in Performance Roadmap Jun 18, 2024
@bowenlan-amzn bowenlan-amzn moved this from In Progress to In-Review in Performance Roadmap Jun 21, 2024
@getsaurabh02 getsaurabh02 added v2.17.0 and removed v2.16.0 Issues and PRs related to version 2.16.0 labels Jul 25, 2024
@github-project-automation github-project-automation bot moved this from In-Review to Done in Performance Roadmap Aug 9, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants