Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type from nested documents; where types used to store nested path information #2357

Closed
Tracked by #1940
dreamer-89 opened this issue Mar 4, 2022 · 6 comments
Assignees
Labels
v2.1.0 Issues and PRs related to version 2.1.0

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Mar 4, 2022

Remove _type field used to store nested paths

@dreamer-89
Copy link
Member Author

dreamer-89 commented Mar 15, 2022

Based on code scan, I think _type references are internal and not exposed to customers. Thus, this change is not a blocking change for v2.0.0. We can target other blocking changes first before picking up this one.

@nknize @reta : What are your thoughts around this ?

@dreamer-89 dreamer-89 self-assigned this Mar 15, 2022
@reta
Copy link
Collaborator

reta commented Mar 15, 2022

@dreamer-89 sounds good, to me, thanks!

@dreamer-89
Copy link
Member Author

https://github.com/dreamer-89/OpenSearch/commits/nested-doc-type

After adding NestedPathFieldMapper to replace _type in nested document's parent/child references.

@dreamer-89
Copy link
Member Author

Confirmed with @nknize ; that this is not a blocking change for 2.0 relase.

@dblock dblock added the v2.1.0 Issues and PRs related to version 2.1.0 label Apr 19, 2022
@dreamer-89
Copy link
Member Author

This is implemented in #3004.

@dreamer-89
Copy link
Member Author

Closing this issue, as relevant PR is merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Development

No branches or pull requests

4 participants