Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Redefine the insync allocations if remote translog is enabled #4506

Closed
Tracked by #4507 ...
ashking94 opened this issue Sep 14, 2022 · 1 comment
Closed
Tracked by #4507 ...
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@ashking94
Copy link
Member

ashking94 commented Sep 14, 2022

Is your feature request related to a problem? Please describe.
Whenever a primary fails and if replicas are available. The master choses to promote a replica that is insync (or active). Since the request to primary is not replicated in sync to the replicas. The definition of insync itself needs to be changed.

Couple of definitions in respect to a shard (in replication tracker) -

  • inSync = whether this shard is treated as in-sync and thus contributes to the global checkpoint calculation
  • tracked = whether this shard is tracked in the replication group, i.e., should receive document updates from the primary
  • pendingInSync = This set contains allocation IDs for which there is a thread actively waiting for the local checkpoint to advance to at least the current global checkpoint

Describe the solution you'd like
all replicas in general can be assumed to be insync (need to find cases where it should not be not relating to checkpoints). This will make the rest of the updates on replica’s replication tracker as obsolete and then we can go on to the next step.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ashking94
Copy link
Member Author

Taken cared off with #5282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

2 participants