Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snapshot Interop] Add Logic for Remote Store Cleanup in Lock Manager if there are no more locks. #8469

Open
harishbhakuni opened this issue Jul 6, 2023 · 0 comments · Fixed by #8472
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage Issues and PRs relating to data and metadata storage

Comments

@harishbhakuni
Copy link
Contributor

harishbhakuni commented Jul 6, 2023

Lock Manager Implementation that we have today only takes care of deletion of locks. Also, Remote Store GC only runs after a flush/refresh. So if a Remote Store Index is deleted but snapshot holds lock on it, there will be some stale segments that we will have in remote store which will never cleanup.

For this, long term solution would be to create a Poller which will periodically looks into cluster state to get the current live indices and then in remote store cleanup all the stale files for indices which are not present in cluster state anymore. Also, Remote Store GC which runs as part of refresh runs asynchronously, so if GC components fails to delete some stale segments, this poller will be responsible for cleanup of those stale files.

As a short term solution, for now we will be extending Lock Manager to cleanup stale segments as well if we are releasing the last lock from the segment store and index is not present in the cluster.

Update : The short term solution is already merged . Reopening this issue for the long term solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework Storage Issues and PRs relating to data and metadata storage
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

6 participants