Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TracerFactory should return wrapped tracer #8561

Closed
Tracked by #7542
Gaganjuneja opened this issue Jul 10, 2023 · 2 comments
Closed
Tracked by #7542

[BUG] TracerFactory should return wrapped tracer #8561

Gaganjuneja opened this issue Jul 10, 2023 · 2 comments
Labels
bug Something isn't working v2.9.0 'Issues and PRs related to version v2.9.0'

Comments

@Gaganjuneja
Copy link
Contributor

Describe the bug
As per comment in this PR, we should return the wrapped Tracer from TracerFactory.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Gaganjuneja Gaganjuneja added bug Something isn't working untriaged labels Jul 10, 2023
@Gaganjuneja
Copy link
Contributor Author

@suranjay Can you please take this up? We can simply write a new implementation of Tracer as a WrappedTracer which can wrap the getTracer() behaviour.

@suranjay
Copy link
Contributor

@suranjay Can you please take this up? We can simply write a new implementation of Tracer as a WrappedTracer which can wrap the getTracer() behaviour.

Sure, on it!

@reta reta added v2.9.0 'Issues and PRs related to version v2.9.0' and removed untriaged labels Jul 11, 2023
@reta reta closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

No branches or pull requests

3 participants