-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Star tree] Handle delete cases for star tree #16380
[Star tree] Handle delete cases for star tree #16380
Conversation
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
5538057
to
80dc4c4
Compare
#16233 - if keyword changes are missing 2.18 timeframe, we will include only this particular PR which contains fixes. Marking the PR as draft for now. |
❌ Gradle check result for 80dc4c4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16380 +/- ##
============================================
- Coverage 72.07% 71.96% -0.12%
+ Complexity 64819 64739 -80
============================================
Files 5307 5308 +1
Lines 302718 302724 +6
Branches 43734 43734
============================================
- Hits 218178 217849 -329
- Misses 66638 66972 +334
- Partials 17902 17903 +1 ☔ View full report in Codecov by Sentry. |
Changes are covered in integ tests but CodeCov does not consider coverage from integ tests, bypassing the check. |
Signed-off-by: Bharathwaj G <bharath78910@gmail.com> (cherry picked from commit ad7f9e7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ad7f9e7) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
When there are delete operations in the index, there are segments where
SegmentDocValuesProducers
is present which containsList<DocValuesProducers>
contrary to segments in index where no deletes are present.So one change is to pick
DocValuesProducer
in the list whereStarTreeValues
is present - usually I see that one field is present only in one of theDocValuesProducer
- evenSegmentDocValuesProducer
has a map ofFieldInfo
toDocValuesProducer
which confirms the same.Secondly there are issues because of
segmentSuffix
missing in the custom write state and read state. So have added the same.Also including fixes from #16124
Related Issues
Resolves #16381
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.