Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Update Gradle to 7.4.1 #2645

Merged
merged 1 commit into from
Mar 30, 2022
Merged

[Backport 2.x] Update Gradle to 7.4.1 #2645

merged 1 commit into from
Mar 30, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 223efe6 from #2078

@reta @github-actions
Update Gradle to 7.4.1 (#2078)
c33401b 
* Update Gradle to 7.4.1

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments, added @PathSensitive(PathSensitivity.RELATIVE) where applicable

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 223efe6)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 29, 2022 16:24
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c33401b
Log 3854

Reports 3854

@dblock
Copy link
Member

dblock commented Mar 29, 2022

Let's keep 2.x on Gradle 7.3.x.

@dblock dblock closed this Mar 29, 2022
@reta
Copy link
Collaborator

reta commented Mar 29, 2022

Let's keep 2.x on Gradle 7.3.x.

@dblock I think for 2.x should be fine, no?

@dblock
Copy link
Member

dblock commented Mar 29, 2022

Let's keep 2.x on Gradle 7.3.x.

@dblock I think for 2.x should be fine, no?

You're right. @peterzhuamazon is switching https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.0.0/opensearch-2.0.0.yml#L13 to 2.0, so I'll reopen this.

@dblock dblock reopened this Mar 29, 2022
@dblock
Copy link
Member

dblock commented Mar 29, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c33401b
Log 3871

Reports 3871

@peterzhuamazon
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c33401b
Log 3872

Reports 3872

@peterzhuamazon
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c33401b
Log 3876

Reports 3876

@peterzhuamazon
Copy link
Member

@reta retried 3 times seems like still complaining.

@reta
Copy link
Collaborator

reta commented Mar 29, 2022

@peterzhuamazon sad state of tests :( the last one is #1746 :(

@peterzhuamazon
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success c33401b
Log 3884

Reports 3884

peterzhuamazon
peterzhuamazon approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reta, need @opensearch-project/opensearch-core members approval.

@reta
Copy link
Collaborator

reta commented Mar 30, 2022

Thanks @reta, need @opensearch-project/opensearch-core members approval.

Thanks a lot for patience, @peterzhuamazon !

@dblock dblock merged commit 8865e75 into 2.x Mar 30, 2022
@github-actions github-actions bot deleted the backport/backport-2078-to-2.x branch March 30, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartg kartg kartg approved these changes

@peterzhuamazon peterzhuamazon peterzhuamazon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@opensearch-ci-bot @dblock @reta @peterzhuamazon @kartg